diff mbox series

[v5,2/3] dt-bindings: media: ov772x: Make bus-type mandatory

Message ID 20200910162055.614089-3-jacopo+renesas@jmondi.org (mailing list archive)
State New, archived
Headers show
Series dt-bindings: media: ov772x: Convert to json-schema | expand

Commit Message

Jacopo Mondi Sept. 10, 2020, 4:20 p.m. UTC 
In order to establish required properties based on the selected
bus type, make the 'bus-type' property mandatory. As this change
documents an endpoint property, also document the 'remote-endpoint'
one now that the 'endpoint' schema has been expanded.

Binary compatibility with existing DTB is kept as the driver does not
enforce the property to be present, and shall fall-back to default
parallel bus configuration, which was the only supported bus type, if
the property is not specified.

Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 .../bindings/media/i2c/ovti,ov772x.yaml          | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Sakari Ailus Sept. 11, 2020, 5:37 a.m. UTC | #1 
Hi Jacopo,

On Thu, Sep 10, 2020 at 06:20:54PM +0200, Jacopo Mondi wrote:
> In order to establish required properties based on the selected
> bus type, make the 'bus-type' property mandatory. As this change
> documents an endpoint property, also document the 'remote-endpoint'
> one now that the 'endpoint' schema has been expanded.
> 
> Binary compatibility with existing DTB is kept as the driver does not
> enforce the property to be present, and shall fall-back to default
> parallel bus configuration, which was the only supported bus type, if
> the property is not specified.

Could you add a comment on this to the driver, so this feature isn't
accidentally removed?
Jacopo Mondi Sept. 11, 2020, 8:58 a.m. UTC | #2 
Hi Sakari,

On Fri, Sep 11, 2020 at 08:37:57AM +0300, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Thu, Sep 10, 2020 at 06:20:54PM +0200, Jacopo Mondi wrote:
> > In order to establish required properties based on the selected
> > bus type, make the 'bus-type' property mandatory. As this change
> > documents an endpoint property, also document the 'remote-endpoint'
> > one now that the 'endpoint' schema has been expanded.
> >
> > Binary compatibility with existing DTB is kept as the driver does not
> > enforce the property to be present, and shall fall-back to default
> > parallel bus configuration, which was the only supported bus type, if
> > the property is not specified.
>
> Could you add a comment on this to the driver, so this feature isn't
> accidentally removed?

Sure, can I send a patch in reply to this series to avoid a v6 ?
>
> --
> Regards,
>
> Sakari Ailus
Lad Prabhakar Sept. 11, 2020, 8:59 a.m. UTC | #3 
Hi Jacopo,

> -----Original Message-----
> From: Jacopo Mondi <jacopo@jmondi.org>
> Sent: 11 September 2020 09:59
> To: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>; robh+dt@kernel.org; devicetree@vger.kernel.org; linux-media@vger.kernel.org; Lad,
> Prabhakar <prabhakar.csengg@gmail.com>; mchehab@kernel.org; hverkuil-cisco@xs4all.nl; laurent.pinchart@ideasonboard.com; linux-
> renesas-soc@vger.kernel.org; Rob Herring <robh@kernel.org>; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: Re: [PATCH v5 2/3] dt-bindings: media: ov772x: Make bus-type mandatory
>
> Hi Sakari,
>
> On Fri, Sep 11, 2020 at 08:37:57AM +0300, Sakari Ailus wrote:
> > Hi Jacopo,
> >
> > On Thu, Sep 10, 2020 at 06:20:54PM +0200, Jacopo Mondi wrote:
> > > In order to establish required properties based on the selected
> > > bus type, make the 'bus-type' property mandatory. As this change
> > > documents an endpoint property, also document the 'remote-endpoint'
> > > one now that the 'endpoint' schema has been expanded.
> > >
> > > Binary compatibility with existing DTB is kept as the driver does not
> > > enforce the property to be present, and shall fall-back to default
> > > parallel bus configuration, which was the only supported bus type, if
> > > the property is not specified.
> >
> > Could you add a comment on this to the driver, so this feature isn't
> > accidentally removed?
>
> Sure, can I send a patch in reply to this series to avoid a v6 ?
If you don’t mind Ill handle this as part of bt656 additions ?

Cheers,
Prabhakar


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
Sakari Ailus Sept. 11, 2020, 9:23 a.m. UTC | #4 
On Fri, Sep 11, 2020 at 08:59:13AM +0000, Prabhakar Mahadev Lad wrote:
> Hi Jacopo,
> 
> > -----Original Message-----
> > From: Jacopo Mondi <jacopo@jmondi.org>
> > Sent: 11 September 2020 09:59
> > To: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>; robh+dt@kernel.org; devicetree@vger.kernel.org; linux-media@vger.kernel.org; Lad,
> > Prabhakar <prabhakar.csengg@gmail.com>; mchehab@kernel.org; hverkuil-cisco@xs4all.nl; laurent.pinchart@ideasonboard.com; linux-
> > renesas-soc@vger.kernel.org; Rob Herring <robh@kernel.org>; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Subject: Re: [PATCH v5 2/3] dt-bindings: media: ov772x: Make bus-type mandatory
> >
> > Hi Sakari,
> >
> > On Fri, Sep 11, 2020 at 08:37:57AM +0300, Sakari Ailus wrote:
> > > Hi Jacopo,
> > >
> > > On Thu, Sep 10, 2020 at 06:20:54PM +0200, Jacopo Mondi wrote:
> > > > In order to establish required properties based on the selected
> > > > bus type, make the 'bus-type' property mandatory. As this change
> > > > documents an endpoint property, also document the 'remote-endpoint'
> > > > one now that the 'endpoint' schema has been expanded.
> > > >
> > > > Binary compatibility with existing DTB is kept as the driver does not
> > > > enforce the property to be present, and shall fall-back to default
> > > > parallel bus configuration, which was the only supported bus type, if
> > > > the property is not specified.
> > >
> > > Could you add a comment on this to the driver, so this feature isn't
> > > accidentally removed?
> >
> > Sure, can I send a patch in reply to this series to avoid a v6 ?
> If you don’t mind Ill handle this as part of bt656 additions ?

Both are fine for me.
Jacopo Mondi Sept. 11, 2020, 9:46 a.m. UTC | #5 
Hi Prabhakar,

On Fri, Sep 11, 2020 at 08:59:13AM +0000, Prabhakar Mahadev Lad wrote:
> Hi Jacopo,
>
> > -----Original Message-----
> > From: Jacopo Mondi <jacopo@jmondi.org>
> > Sent: 11 September 2020 09:59
> > To: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>; robh+dt@kernel.org; devicetree@vger.kernel.org; linux-media@vger.kernel.org; Lad,
> > Prabhakar <prabhakar.csengg@gmail.com>; mchehab@kernel.org; hverkuil-cisco@xs4all.nl; laurent.pinchart@ideasonboard.com; linux-
> > renesas-soc@vger.kernel.org; Rob Herring <robh@kernel.org>; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Subject: Re: [PATCH v5 2/3] dt-bindings: media: ov772x: Make bus-type mandatory
> >
> > Hi Sakari,
> >
> > On Fri, Sep 11, 2020 at 08:37:57AM +0300, Sakari Ailus wrote:
> > > Hi Jacopo,
> > >
> > > On Thu, Sep 10, 2020 at 06:20:54PM +0200, Jacopo Mondi wrote:
> > > > In order to establish required properties based on the selected
> > > > bus type, make the 'bus-type' property mandatory. As this change
> > > > documents an endpoint property, also document the 'remote-endpoint'
> > > > one now that the 'endpoint' schema has been expanded.
> > > >
> > > > Binary compatibility with existing DTB is kept as the driver does not
> > > > enforce the property to be present, and shall fall-back to default
> > > > parallel bus configuration, which was the only supported bus type, if
> > > > the property is not specified.
> > >
> > > Could you add a comment on this to the driver, so this feature isn't
> > > accidentally removed?
> >
> > Sure, can I send a patch in reply to this series to avoid a v6 ?
> If you don’t mind Ill handle this as part of bt656 additions ?

It's not an issue for me. From a process perspective it might be
better if we know that comment and this series gets merged in the same
release to avoid 'holes', but if you're confident the BT.656 series will
land at the same time please go ahead!

>
> Cheers,
> Prabhakar
>
>
> Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
index e7e2d31fcc23..b034953b92e9 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
@@ -41,6 +41,21 @@  properties:
     description: |
       Video output port. See ../video-interfaces.txt.
 
+    properties:
+      endpoint:
+        type: object
+
+        properties:
+          bus-type:
+            enum: [5, 6]
+
+        required:
+          - bus-type
+
+        unevaluatedProperties: false
+
+    additionalProperties: false
+
 required:
   - compatible
   - reg
@@ -65,6 +80,7 @@  examples:
 
             port {
                 ov772x_0: endpoint {
+                    bus-type = <5>;
                     remote-endpoint = <&vcap1_in0>;
                 };
             };