From patchwork Mon Sep 21 16:23:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11790469 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1D056618 for ; Mon, 21 Sep 2020 16:26:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02C04238D7 for ; Mon, 21 Sep 2020 16:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600705598; bh=8mnrw8vcPI3JMN8evy2QkG/hMKKVSLWHoPB9QX3PfK0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ZiAtnVJTaEt99KcL9Z8d6w5spWZHP80O2FyKowIMokjD0C9sgJysSCpxG1d/Pz2Eb 3fbIYjdNYg0rzMbI9HfKbiJAYVdr7q7tL9VjyQbdxdTId0SlRvgeQnv3RsM89mSXUN TGE5NRN0O/rBYg4Psf8VEES3oxNl+JlQg7v5OHWY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728026AbgIUQ0e (ORCPT ); Mon, 21 Sep 2020 12:26:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:53108 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726795AbgIUQ0e (ORCPT ); Mon, 21 Sep 2020 12:26:34 -0400 Received: from localhost.localdomain (unknown [194.230.155.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3269E2388E; Mon, 21 Sep 2020 16:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600705593; bh=8mnrw8vcPI3JMN8evy2QkG/hMKKVSLWHoPB9QX3PfK0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xEBS3/YCJ8PWTNz/u0z/87ZrL+HMtVAvjLoj36CvzsuMXkptHlWhWteiPuURpx0Vv eqMNTybTzyfZr5rJjJ9OiLitzAkb3ffhAoS7MKkTx13DhrY4weyWKEI2EIxztLI6D2 FwX1yULG45R95Gpnf9wl8fa6aE874U3WXYBmGn/s= From: Krzysztof Kozlowski To: Pavel Machek , Sakari Ailus , Mauro Carvalho Chehab , Lars-Peter Clausen , Tianshu Qiu , Dongchun Zhu , Shawn Tu , Ricardo Ribalda , Dave Stevenson , Manivannan Sadhasivam , Bingbu Cao , Rui Miguel Silva , Shunqian Zheng , Chiranjeevi Rapolu , Hyungwoo Yang , Wenyou Yang , Hans Verkuil , Marco Felsch , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 19/25] media: i2c: ov5670: simplify getting state container Date: Mon, 21 Sep 2020 18:23:36 +0200 Message-Id: <20200921162342.7348-19-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200921162342.7348-1-krzk@kernel.org> References: <20200921162342.7348-1-krzk@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The pointer to 'struct v4l2_subdev' is stored in drvdata via v4l2_i2c_subdev_init() so there is no point of a dance like: struct i2c_client *client = to_i2c_client(struct device *dev) struct v4l2_subdev *sd = i2c_get_clientdata(client); This allows to remove local variable 'client' and few pointer dereferences. Signed-off-by: Krzysztof Kozlowski --- drivers/media/i2c/ov5670.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov5670.c b/drivers/media/i2c/ov5670.c index f26252e35e08..148fd4e05029 100644 --- a/drivers/media/i2c/ov5670.c +++ b/drivers/media/i2c/ov5670.c @@ -2373,8 +2373,7 @@ static int ov5670_set_stream(struct v4l2_subdev *sd, int enable) static int __maybe_unused ov5670_suspend(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov5670 *ov5670 = to_ov5670(sd); if (ov5670->streaming) @@ -2385,8 +2384,7 @@ static int __maybe_unused ov5670_suspend(struct device *dev) static int __maybe_unused ov5670_resume(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov5670 *ov5670 = to_ov5670(sd); int ret;