| Message ID | 20200922165813.19378-2-dafna.hirschfeld@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add format MEDIA_BUS_FMT_METADATA_FIXED and use it in rkisp1 | expand |
On 9/22/20 1:58 PM, Dafna Hirschfeld wrote: > MEDIA_BUS_FMT_METADATA_FIXED should be used when > the same driver handles both sides of the link and > the bus format is a fixed metadata format that is > not configurable from userspace. > > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Acked-by: Helen Koike <helen.koike@collabora.com> Thanks Helen > --- > include/uapi/linux/media-bus-format.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h > index 84fa53ffb13f..847b45fb546b 100644 > --- a/include/uapi/linux/media-bus-format.h > +++ b/include/uapi/linux/media-bus-format.h > @@ -156,4 +156,12 @@ > /* HSV - next is 0x6002 */ > #define MEDIA_BUS_FMT_AHSV8888_1X32 0x6001 > > +/* > + * This format should be used when the same driver handles > + * both sides of the link and the bus format is a fixed > + * metadata format that is not configurable from userspace. > + * This format may have 0 height and width. > + */ > +#define MEDIA_BUS_FMT_METADATA_FIXED 0x7001 > + > #endif /* __LINUX_MEDIA_BUS_FORMAT_H */ >
On 14/10/2020 22:40, Helen Koike wrote: > > > On 9/22/20 1:58 PM, Dafna Hirschfeld wrote: >> MEDIA_BUS_FMT_METADATA_FIXED should be used when >> the same driver handles both sides of the link and >> the bus format is a fixed metadata format that is >> not configurable from userspace. >> >> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> > > Acked-by: Helen Koike <helen.koike@collabora.com> > > Thanks > Helen > >> --- >> include/uapi/linux/media-bus-format.h | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h >> index 84fa53ffb13f..847b45fb546b 100644 >> --- a/include/uapi/linux/media-bus-format.h >> +++ b/include/uapi/linux/media-bus-format.h >> @@ -156,4 +156,12 @@ >> /* HSV - next is 0x6002 */ >> #define MEDIA_BUS_FMT_AHSV8888_1X32 0x6001 >> >> +/* >> + * This format should be used when the same driver handles >> + * both sides of the link and the bus format is a fixed >> + * metadata format that is not configurable from userspace. >> + * This format may have 0 height and width. I would make this stronger: "Width and height will be set to 0 for this format." Regards, Hans >> + */ >> +#define MEDIA_BUS_FMT_METADATA_FIXED 0x7001 >> + >> #endif /* __LINUX_MEDIA_BUS_FORMAT_H */ >>
diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h index 84fa53ffb13f..847b45fb546b 100644 --- a/include/uapi/linux/media-bus-format.h +++ b/include/uapi/linux/media-bus-format.h @@ -156,4 +156,12 @@ /* HSV - next is 0x6002 */ #define MEDIA_BUS_FMT_AHSV8888_1X32 0x6001 +/* + * This format should be used when the same driver handles + * both sides of the link and the bus format is a fixed + * metadata format that is not configurable from userspace. + * This format may have 0 height and width. + */ +#define MEDIA_BUS_FMT_METADATA_FIXED 0x7001 + #endif /* __LINUX_MEDIA_BUS_FORMAT_H */
MEDIA_BUS_FMT_METADATA_FIXED should be used when the same driver handles both sides of the link and the bus format is a fixed metadata format that is not configurable from userspace. Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> --- include/uapi/linux/media-bus-format.h | 8 ++++++++ 1 file changed, 8 insertions(+)