| Message ID | 20201006104414.67984-5-ezequiel@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | CODA timeout fix & assorted changes | expand |
On Tue, 2020-10-06 at 07:44 -0300, Ezequiel Garcia wrote: > Make interrupt naming more consistent by using a common > pattern for video and jpeg interrupts. > > With this commit, interrupts are shown as: > > 29: 0 0 GPC 12 Level coda-video > 30: 0 0 GPC 3 Level coda-jpeg > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > --- > drivers/media/platform/coda/coda-common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c > index a72ea4bb37d7..487dd653b24a 100644 > --- a/drivers/media/platform/coda/coda-common.c > +++ b/drivers/media/platform/coda/coda-common.c > @@ -3153,7 +3153,7 @@ static int coda_probe(struct platform_device *pdev) > return irq; > > ret = devm_request_irq(&pdev->dev, irq, coda_irq_handler, 0, > - dev_name(&pdev->dev), dev); > + CODA_NAME "-video", dev); > if (ret < 0) { > dev_err(&pdev->dev, "failed to request irq: %d\n", ret); > return ret; > @@ -3167,7 +3167,7 @@ static int coda_probe(struct platform_device *pdev) > > ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, > coda9_jpeg_irq_handler, > - IRQF_ONESHOT, CODA_NAME " jpeg", > + IRQF_ONESHOT, CODA_NAME "-jpeg", > dev); > if (ret < 0) { > dev_err(&pdev->dev, "failed to request jpeg irq\n"); I don't care very much for this, but I don't mind either. Acked-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c index a72ea4bb37d7..487dd653b24a 100644 --- a/drivers/media/platform/coda/coda-common.c +++ b/drivers/media/platform/coda/coda-common.c @@ -3153,7 +3153,7 @@ static int coda_probe(struct platform_device *pdev) return irq; ret = devm_request_irq(&pdev->dev, irq, coda_irq_handler, 0, - dev_name(&pdev->dev), dev); + CODA_NAME "-video", dev); if (ret < 0) { dev_err(&pdev->dev, "failed to request irq: %d\n", ret); return ret; @@ -3167,7 +3167,7 @@ static int coda_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, coda9_jpeg_irq_handler, - IRQF_ONESHOT, CODA_NAME " jpeg", + IRQF_ONESHOT, CODA_NAME "-jpeg", dev); if (ret < 0) { dev_err(&pdev->dev, "failed to request jpeg irq\n");
Make interrupt naming more consistent by using a common pattern for video and jpeg interrupts. With this commit, interrupts are shown as: 29: 0 0 GPC 12 Level coda-video 30: 0 0 GPC 3 Level coda-jpeg Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> --- drivers/media/platform/coda/coda-common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)