| Message ID | 20201012180414.11579-7-sakari.ailus@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ipu3-cio2 format and other fixes | expand |
On Mon, Oct 12, 2020 at 9:09 PM Sakari Ailus <sakari.ailus@linux.intel.com> wrote: > > Now that the values are unsigned, we can remove explicit cast to u32. the explicit Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > drivers/media/pci/intel/ipu3/ipu3-cio2.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > index 87d040e176f7..e42177f8c426 100644 > --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c > +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > @@ -1282,9 +1282,8 @@ static int cio2_subdev_set_fmt(struct v4l2_subdev *sd, > } > } > > - fmt->format.width = min_t(u32, fmt->format.width, CIO2_IMAGE_MAX_WIDTH); > - fmt->format.height = min_t(u32, fmt->format.height, > - CIO2_IMAGE_MAX_LENGTH); > + fmt->format.width = min(fmt->format.width, CIO2_IMAGE_MAX_WIDTH); > + fmt->format.height = min(fmt->format.height, CIO2_IMAGE_MAX_LENGTH); > fmt->format.field = V4L2_FIELD_NONE; > > mutex_lock(&q->subdev_lock); > -- > 2.27.0 >
Hi Sakari, Thank you for the patch. On Mon, Oct 12, 2020 at 09:04:12PM +0300, Sakari Ailus wrote: > Now that the values are unsigned, we can remove explicit cast to u32. > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> With Andy's comment addressed, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/pci/intel/ipu3/ipu3-cio2.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > index 87d040e176f7..e42177f8c426 100644 > --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c > +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > @@ -1282,9 +1282,8 @@ static int cio2_subdev_set_fmt(struct v4l2_subdev *sd, > } > } > > - fmt->format.width = min_t(u32, fmt->format.width, CIO2_IMAGE_MAX_WIDTH); > - fmt->format.height = min_t(u32, fmt->format.height, > - CIO2_IMAGE_MAX_LENGTH); > + fmt->format.width = min(fmt->format.width, CIO2_IMAGE_MAX_WIDTH); > + fmt->format.height = min(fmt->format.height, CIO2_IMAGE_MAX_LENGTH); > fmt->format.field = V4L2_FIELD_NONE; > > mutex_lock(&q->subdev_lock);
diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c index 87d040e176f7..e42177f8c426 100644 --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c @@ -1282,9 +1282,8 @@ static int cio2_subdev_set_fmt(struct v4l2_subdev *sd, } } - fmt->format.width = min_t(u32, fmt->format.width, CIO2_IMAGE_MAX_WIDTH); - fmt->format.height = min_t(u32, fmt->format.height, - CIO2_IMAGE_MAX_LENGTH); + fmt->format.width = min(fmt->format.width, CIO2_IMAGE_MAX_WIDTH); + fmt->format.height = min(fmt->format.height, CIO2_IMAGE_MAX_LENGTH); fmt->format.field = V4L2_FIELD_NONE; mutex_lock(&q->subdev_lock);
Now that the values are unsigned, we can remove explicit cast to u32. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/media/pci/intel/ipu3/ipu3-cio2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)