From patchwork Thu Oct 29 16:42:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11866839 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E10BE14B7 for ; Thu, 29 Oct 2020 16:43:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF3142151B for ; Thu, 29 Oct 2020 16:43:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603989811; bh=M9OkRSe1IB/IvBo2pbX48CkeYtZxfgjwWQKbtDopf68=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GH9j5wrzYMkHtwViJbeg1AcuRRbyLd8P+QVBl53YgSIszwmx1BglYVvWPWUTiSOYr GyG+SsxfGSvTpjUoVi1D3GeAdhJqoDg4VoZ7D8b1P/gvGQVS99UrQitsAJ3ZkWvXDY Zn/FXfDzk16bp1P/HBDrr1nQlg3X1GC1egyHkey4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727143AbgJ2Qna (ORCPT ); Thu, 29 Oct 2020 12:43:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:51980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727141AbgJ2Qn3 (ORCPT ); Thu, 29 Oct 2020 12:43:29 -0400 Received: from localhost.localdomain (adsl-84-226-167-205.adslplus.ch [84.226.167.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EF5C0214DB; Thu, 29 Oct 2020 16:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603989808; bh=M9OkRSe1IB/IvBo2pbX48CkeYtZxfgjwWQKbtDopf68=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ISPt386+hBOa1mmOshodzbJWwYt7DxJRKV5hMXSM5bbWgxoeJxJzwg71SD65yM2OY ZJ2hjjGUwvBaIbgiK23tLfiUr0IDr+ZYzsjaHYvwS6Uj/PG6riBqJvXdsCuRpWLyPg fkTkxwxQ3r7IF2gEpqg2tp5la3tnqAvYMgJtHeV4= From: Krzysztof Kozlowski To: Pavel Machek , Sakari Ailus , Mauro Carvalho Chehab , Lars-Peter Clausen , Tianshu Qiu , Dongchun Zhu , Shawn Tu , Ricardo Ribalda , Dave Stevenson , Manivannan Sadhasivam , Bingbu Cao , Rui Miguel Silva , Shunqian Zheng , Chiranjeevi Rapolu , Hyungwoo Yang , Wenyou Yang , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RESEND PATCH 10/25] media: i2c: adv7180: simplify getting state container Date: Thu, 29 Oct 2020 17:42:24 +0100 Message-Id: <20201029164239.84240-10-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201029164239.84240-1-krzk@kernel.org> References: <20201029164239.84240-1-krzk@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The pointer to 'struct v4l2_subdev' is stored in drvdata via v4l2_i2c_subdev_init() so there is no point of a dance like: struct i2c_client *client = to_i2c_client(struct device *dev) struct v4l2_subdev *sd = i2c_get_clientdata(client); This allows to remove local variable 'client' and few pointer dereferences. Signed-off-by: Krzysztof Kozlowski --- drivers/media/i2c/adv7180.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index 4498d14d3429..44bb6fe85644 100644 --- a/drivers/media/i2c/adv7180.c +++ b/drivers/media/i2c/adv7180.c @@ -1454,8 +1454,7 @@ MODULE_DEVICE_TABLE(i2c, adv7180_id); #ifdef CONFIG_PM_SLEEP static int adv7180_suspend(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct adv7180_state *state = to_state(sd); return adv7180_set_power(state, false); @@ -1463,8 +1462,7 @@ static int adv7180_suspend(struct device *dev) static int adv7180_resume(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct adv7180_state *state = to_state(sd); int ret;