From patchwork Thu Oct 29 16:42:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11866851 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DDB641130 for ; Thu, 29 Oct 2020 16:43:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC50E20825 for ; Thu, 29 Oct 2020 16:43:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603989836; bh=6mIHa/ObVyPo2R/u+eryKdODkXE97s7lir+Hh6dLp9I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NuiJ0puDf+MTiLe04EsjQUZ3zKzSr0eZZvKD/kUbxdshPIV3KHWH2AtnrSHlZlSM9 MgN8ZFJoF97ffQY0iF4HwMUoMoZVBESHAUHW6CFTmm9FKk8KSJfFuRbVrJ/XPPt3g/ wYmlizXhIBBiUmJnDJ6P525shXa4cprVpKI45BVw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727373AbgJ2Qnw (ORCPT ); Thu, 29 Oct 2020 12:43:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:52456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727079AbgJ2Qnv (ORCPT ); Thu, 29 Oct 2020 12:43:51 -0400 Received: from localhost.localdomain (adsl-84-226-167-205.adslplus.ch [84.226.167.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 18B5721481; Thu, 29 Oct 2020 16:43:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603989830; bh=6mIHa/ObVyPo2R/u+eryKdODkXE97s7lir+Hh6dLp9I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m4hbIaDJE9digDF+r1MaUhczhUrRZoYSUwC56+Nr2KYzFydge2S3HIhvHLwQmiQQo FelxSebQLoKAFy8PSxJvfzJBH9kfFY2ugr1vI0z0Cd35RlzSgtGqauEu4dCRK7/ZVk TP9DUvjDZnXQ1P4cnZ0oJ/Ru2UE4HY7kOpu3CFuE= From: Krzysztof Kozlowski To: Pavel Machek , Sakari Ailus , Mauro Carvalho Chehab , Lars-Peter Clausen , Tianshu Qiu , Dongchun Zhu , Shawn Tu , Ricardo Ribalda , Dave Stevenson , Manivannan Sadhasivam , Bingbu Cao , Rui Miguel Silva , Shunqian Zheng , Chiranjeevi Rapolu , Hyungwoo Yang , Wenyou Yang , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RESEND PATCH 15/25] media: i2c: ov13858: simplify getting state container Date: Thu, 29 Oct 2020 17:42:29 +0100 Message-Id: <20201029164239.84240-15-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201029164239.84240-1-krzk@kernel.org> References: <20201029164239.84240-1-krzk@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The pointer to 'struct v4l2_subdev' is stored in drvdata via v4l2_i2c_subdev_init() so there is no point of a dance like: struct i2c_client *client = to_i2c_client(struct device *dev) struct v4l2_subdev *sd = i2c_get_clientdata(client); This allows to remove local variable 'client' and few pointer dereferences. Signed-off-by: Krzysztof Kozlowski --- drivers/media/i2c/ov13858.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov13858.c b/drivers/media/i2c/ov13858.c index 236ad2c816b7..2f3be7a80cef 100644 --- a/drivers/media/i2c/ov13858.c +++ b/drivers/media/i2c/ov13858.c @@ -1505,8 +1505,7 @@ static int ov13858_set_stream(struct v4l2_subdev *sd, int enable) static int __maybe_unused ov13858_suspend(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov13858 *ov13858 = to_ov13858(sd); if (ov13858->streaming) @@ -1517,8 +1516,7 @@ static int __maybe_unused ov13858_suspend(struct device *dev) static int __maybe_unused ov13858_resume(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov13858 *ov13858 = to_ov13858(sd); int ret;