From patchwork Thu Oct 29 16:42:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11866861 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2BA681130 for ; Thu, 29 Oct 2020 16:44:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0822D2151B for ; Thu, 29 Oct 2020 16:44:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603989859; bh=yn+fZIJ73/uxpxzu+DIH9FgNN9ZUes6fMN5U/XX2iUs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ZRtXamdMIdV0YuI5M1Hg6c+1yweLpAWRlPtgjQc8U4JTw3iSAXpo5PsOSHRUJEUnh 5fXOTcJZz5VSGtGE3ST91VckhXLkh84TSl3xBpb4Sot4zdIQLmvUVWsiEN5SoMYPnr GWSXOQJTnWjCGkqoBHcLdW1h9DWlN7A5MQoA47Bs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727562AbgJ2QoB (ORCPT ); Thu, 29 Oct 2020 12:44:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:52678 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727000AbgJ2Qn7 (ORCPT ); Thu, 29 Oct 2020 12:43:59 -0400 Received: from localhost.localdomain (adsl-84-226-167-205.adslplus.ch [84.226.167.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D765C20EDD; Thu, 29 Oct 2020 16:43:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603989838; bh=yn+fZIJ73/uxpxzu+DIH9FgNN9ZUes6fMN5U/XX2iUs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kf0OxlnjX6t0W5XG3QyV5/ylGzKpQuxxZt9J43hbcp3xga58Cw5+W5LYeMYpEycrR oKIoEoOrg5B+9hWla2LLhZkPs5WkFs7oKjwUDpkD/l2KCfo/Es+qJs/E3cYwYfyUxQ ynqj1asFtnKsOHyGjQQ2u7FRe4IGiAay/ku4r1tM= From: Krzysztof Kozlowski To: Pavel Machek , Sakari Ailus , Mauro Carvalho Chehab , Lars-Peter Clausen , Tianshu Qiu , Dongchun Zhu , Shawn Tu , Ricardo Ribalda , Dave Stevenson , Manivannan Sadhasivam , Bingbu Cao , Rui Miguel Silva , Shunqian Zheng , Chiranjeevi Rapolu , Hyungwoo Yang , Wenyou Yang , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RESEND PATCH 17/25] media: i2c: ov2685: simplify getting state container Date: Thu, 29 Oct 2020 17:42:31 +0100 Message-Id: <20201029164239.84240-17-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201029164239.84240-1-krzk@kernel.org> References: <20201029164239.84240-1-krzk@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The pointer to 'struct v4l2_subdev' is stored in drvdata via v4l2_i2c_subdev_init() so there is no point of a dance like: struct i2c_client *client = to_i2c_client(struct device *dev) struct v4l2_subdev *sd = i2c_get_clientdata(client); This allows to remove local variable 'client' and few pointer dereferences. Signed-off-by: Krzysztof Kozlowski --- drivers/media/i2c/ov2685.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov2685.c b/drivers/media/i2c/ov2685.c index 6814583d9606..49a2dcedb347 100644 --- a/drivers/media/i2c/ov2685.c +++ b/drivers/media/i2c/ov2685.c @@ -506,8 +506,7 @@ static int ov2685_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh) static int __maybe_unused ov2685_runtime_resume(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov2685 *ov2685 = to_ov2685(sd); return __ov2685_power_on(ov2685); @@ -515,8 +514,7 @@ static int __maybe_unused ov2685_runtime_resume(struct device *dev) static int __maybe_unused ov2685_runtime_suspend(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov2685 *ov2685 = to_ov2685(sd); __ov2685_power_off(ov2685);