From patchwork Thu Oct 29 16:42:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11866869 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2D2476A2 for ; Thu, 29 Oct 2020 16:44:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AF6E206F4 for ; Thu, 29 Oct 2020 16:44:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603989877; bh=ohN4jmPLLF9AI0D2GnfqRAKU399Z6v8OgaI8Km2IjrA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=sCtly4jkfAX0yNb7bdZnTlddPpxi9cb0ivQ9c4MHJZhK2AQC4E1Y6H7B3oFueapKN E+Is8868gE64Rz5aJc124Wkjwqzn8SzZ3bT4nsyTLSPkj94yX72ibz/TmSLx+UHxJI N6+nUij6N/FMDHQPou9LcbH7QWXcv4+JjWAnNGYk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727657AbgJ2QoS (ORCPT ); Thu, 29 Oct 2020 12:44:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:53118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727661AbgJ2QoQ (ORCPT ); Thu, 29 Oct 2020 12:44:16 -0400 Received: from localhost.localdomain (adsl-84-226-167-205.adslplus.ch [84.226.167.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19230206F4; Thu, 29 Oct 2020 16:44:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603989855; bh=ohN4jmPLLF9AI0D2GnfqRAKU399Z6v8OgaI8Km2IjrA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=adRyuKQqJZsq8ejIs3fGkH+qCZXScN/2jIBjQyLj4gFrdOOpNAIUgRsXZ5+zpj/L5 poOwCKEVxvVtdSgM5CjisVpmCdztytf8gAC1it2t4SRierG4bZNtkuPRkMS6JjOWMp N7U/mmGkrMApBtcyh9SWcf/nHNfOQXowOvQWJnps= From: Krzysztof Kozlowski To: Pavel Machek , Sakari Ailus , Mauro Carvalho Chehab , Lars-Peter Clausen , Tianshu Qiu , Dongchun Zhu , Shawn Tu , Ricardo Ribalda , Dave Stevenson , Manivannan Sadhasivam , Bingbu Cao , Rui Miguel Silva , Shunqian Zheng , Chiranjeevi Rapolu , Hyungwoo Yang , Wenyou Yang , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RESEND PATCH 21/25] media: i2c: ov5695: simplify getting state container Date: Thu, 29 Oct 2020 17:42:35 +0100 Message-Id: <20201029164239.84240-21-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201029164239.84240-1-krzk@kernel.org> References: <20201029164239.84240-1-krzk@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The pointer to 'struct v4l2_subdev' is stored in drvdata via v4l2_i2c_subdev_init() so there is no point of a dance like: struct i2c_client *client = to_i2c_client(struct device *dev) struct v4l2_subdev *sd = i2c_get_clientdata(client); This allows to remove local variable 'client' and few pointer dereferences. Signed-off-by: Krzysztof Kozlowski --- drivers/media/i2c/ov5695.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov5695.c b/drivers/media/i2c/ov5695.c index cc678d9d2e0d..bbccb6f9582f 100644 --- a/drivers/media/i2c/ov5695.c +++ b/drivers/media/i2c/ov5695.c @@ -1033,8 +1033,7 @@ static void __ov5695_power_off(struct ov5695 *ov5695) static int __maybe_unused ov5695_runtime_resume(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov5695 *ov5695 = to_ov5695(sd); return __ov5695_power_on(ov5695); @@ -1042,8 +1041,7 @@ static int __maybe_unused ov5695_runtime_resume(struct device *dev) static int __maybe_unused ov5695_runtime_suspend(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov5695 *ov5695 = to_ov5695(sd); __ov5695_power_off(ov5695);