From patchwork Thu Oct 29 16:42:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11866865 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6F8C21130 for ; Thu, 29 Oct 2020 16:44:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C8FA214DB for ; Thu, 29 Oct 2020 16:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603989867; bh=/ufwUgDdAZelFPtH61EoRk+exJnD63S/BqZaAPwIBKI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=P9IJbUSUg/RoUo4jbjKc88YYcJhEnO21Y0bhCQP0DC81tCXJ2s21/Jo4lm4AYKWNY Wgaejd/NMkDXVXs5SqxL4lA+QwZKwnd9WDiR+C+xBYxRcz374va1CF83T3mHnj0DKT lsXXgJ9yuD2dV7lT/TTmz4EofCVNSpxi+qoSfdPo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727928AbgJ2Qo0 (ORCPT ); Thu, 29 Oct 2020 12:44:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:53360 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727915AbgJ2QoY (ORCPT ); Thu, 29 Oct 2020 12:44:24 -0400 Received: from localhost.localdomain (adsl-84-226-167-205.adslplus.ch [84.226.167.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5066E20FC3; Thu, 29 Oct 2020 16:44:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603989864; bh=/ufwUgDdAZelFPtH61EoRk+exJnD63S/BqZaAPwIBKI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QCXn6g62S5H4ubvQYGNNgJBYMQ0Bx9MYgpnWcyMWUDP4D4VC8IznQWTae5A6IONE3 YRHa/PZRgpfYk4yo5Xx3LzQQYdRBFBtkeOXyfjMsNXOL5/iCcjS6oGfDUJdAcpM/go qbF084o63w87rAkcGcGg7QwOZbXsAydL42DSXRcQ= From: Krzysztof Kozlowski To: Pavel Machek , Sakari Ailus , Mauro Carvalho Chehab , Lars-Peter Clausen , Tianshu Qiu , Dongchun Zhu , Shawn Tu , Ricardo Ribalda , Dave Stevenson , Manivannan Sadhasivam , Bingbu Cao , Rui Miguel Silva , Shunqian Zheng , Chiranjeevi Rapolu , Hyungwoo Yang , Wenyou Yang , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RESEND PATCH 23/25] media: i2c: ov8856: simplify getting state container Date: Thu, 29 Oct 2020 17:42:37 +0100 Message-Id: <20201029164239.84240-23-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201029164239.84240-1-krzk@kernel.org> References: <20201029164239.84240-1-krzk@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The pointer to 'struct v4l2_subdev' is stored in drvdata via v4l2_i2c_subdev_init() so there is no point of a dance like: struct i2c_client *client = to_i2c_client(struct device *dev) struct v4l2_subdev *sd = i2c_get_clientdata(client); This allows to remove local variable 'client' and few pointer dereferences. Signed-off-by: Krzysztof Kozlowski --- drivers/media/i2c/ov8856.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov8856.c index 2f4ceaa80593..d8cefd3d4045 100644 --- a/drivers/media/i2c/ov8856.c +++ b/drivers/media/i2c/ov8856.c @@ -1417,8 +1417,7 @@ static void __ov8856_power_off(struct ov8856 *ov8856) static int __maybe_unused ov8856_suspend(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov8856 *ov8856 = to_ov8856(sd); mutex_lock(&ov8856->mutex); @@ -1433,8 +1432,7 @@ static int __maybe_unused ov8856_suspend(struct device *dev) static int __maybe_unused ov8856_resume(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov8856 *ov8856 = to_ov8856(sd); int ret;