mbox series

[GIT,PULL,for,v5.10-rc6] vidtv driver fixes

Message ID 20201127134100.101be34e@coco.lan (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL,for,v5.10-rc6] vidtv driver fixes | expand

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v5.10-3

Message

Mauro Carvalho Chehab Nov. 27, 2020, 12:41 p.m. UTC
Hi Linus,

Please pull from:
  git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v5.10-3

For a series of fixes for the new the virtual digital TV driver (vidtv),
which is meant to help doing tests with the digital TV core and media
userspace apps and libraries.

They cover a series of issues I found on it, together with a few new things
in order to make it easier to detect problems at the DVB core.


Regards,
Mauro

The following changes since commit 9215f6bb4705ffe205885411394732bfc439dee0:

  media: venus: pm_helpers: Fix kernel module reload (2020-11-16 19:06:10 +0100)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v5.10-3

for you to fetch changes up to 44f28934af141149959c4e6495bb60c1903bda32:

  media: vidtv.rst: add kernel-doc markups (2020-11-26 08:05:24 +0100)

----------------------------------------------------------------
media fixes for v5.10-rc6

----------------------------------------------------------------
Daniel W. S. Almeida (6):
      media: vidtv: extract the initial CRC value to into a #define
      media: vidtv: psi: add a Network Information Table (NIT)
      media: vidtv: psi: Implement an Event Information Table (EIT)
      media: vidtv: psi: extract descriptor chaining code into a helper
      media: vidtv: Move s302m specific fields into encoder context
      media: vidtv: psi: fix missing assignments in while loops

Mauro Carvalho Chehab (30):
      media: vidtv: reorganize includes
      media: vidtv: add error checks
      media: vidtv: don't use recursive functions
      media: vidtv: fix the name of the program
      media: vidtv: fix the tone generator logic
      media: vidtv: fix some notes at the tone generator
      media: vidtv: avoid data copy when initializing the multiplexer
      media: vidtv: avoid copying data for PES structs
      media: vidtv: do some cleanups at the driver
      media: vidtv: remove some unused functions
      media: vidtv: pre-initialize mux arrays
      media: vidtv: cleanup null packet initialization logic
      media: vidtv: improve EIT data
      media: vidtv: fix the network ID range
      media: vidtv: properly fill EIT service_id
      media: vidtv: add a PID entry for the NIT table
      media: vidtv: fix service type
      media: vidtv: fix service_id at SDT table
      media: vidtv: add date to the current event
      media: vidtv: simplify PSI write function
      media: vidtv: simplify the crc writing logic
      media: vidtv: cleanup PSI descriptor write function
      media: vidtv: cleanup PSI table header function
      media: vidtv: cleanup PAT write function
      media: vidtv: cleanup PMT write table function
      media: vidtv: simplify SDT write function
      media: vidtv: simplify NIT write function
      media: vidtv: simplify EIT write function
      media: vidtv.rst: update vidtv documentation
      media: vidtv.rst: add kernel-doc markups

 Documentation/driver-api/media/drivers/vidtv.rst |  120 +-
 drivers/media/test-drivers/vidtv/vidtv_bridge.c  |  116 +-
 drivers/media/test-drivers/vidtv/vidtv_bridge.h  |    4 +-
 drivers/media/test-drivers/vidtv/vidtv_channel.c |  312 ++++-
 drivers/media/test-drivers/vidtv/vidtv_channel.h |   11 +-
 drivers/media/test-drivers/vidtv/vidtv_common.h  |    1 -
 drivers/media/test-drivers/vidtv/vidtv_demod.c   |    2 +-
 drivers/media/test-drivers/vidtv/vidtv_demod.h   |   11 +-
 drivers/media/test-drivers/vidtv/vidtv_encoder.h |    9 +-
 drivers/media/test-drivers/vidtv/vidtv_mux.c     |  248 ++--
 drivers/media/test-drivers/vidtv/vidtv_mux.h     |   21 +-
 drivers/media/test-drivers/vidtv/vidtv_pes.c     |  179 ++-
 drivers/media/test-drivers/vidtv/vidtv_pes.h     |    8 +-
 drivers/media/test-drivers/vidtv/vidtv_psi.c     | 1521 ++++++++++++++++------
 drivers/media/test-drivers/vidtv/vidtv_psi.h     |  282 +++-
 drivers/media/test-drivers/vidtv/vidtv_s302m.c   |  125 +-
 drivers/media/test-drivers/vidtv/vidtv_s302m.h   |    9 +-
 drivers/media/test-drivers/vidtv/vidtv_ts.c      |    5 +-
 drivers/media/test-drivers/vidtv/vidtv_ts.h      |    5 +-
 drivers/media/test-drivers/vidtv/vidtv_tuner.c   |    5 +-
 drivers/media/test-drivers/vidtv/vidtv_tuner.h   |    1 +
 21 files changed, 2182 insertions(+), 813 deletions(-)

Comments

Jenkins Nov. 27, 2020, 1:09 p.m. UTC | #1
From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/20201127134100.101be34e@coco.lan/
Build log: https://builder.linuxtv.org/job/patchwork/78851/
Build time: 00:16:21
Link: https://lore.kernel.org/linux-media/20201127134100.101be34e@coco.lan

gpg: Signature made Fri 27 Nov 2020 12:34:41 PM UTC
gpg:                using RSA key F909AE68FC11DF09C1755C00085F3EBD8EE4E115
gpg: Good signature from "Mauro Carvalho Chehab <mchehab+huawei@kernel.org>" [ultimate]
gpg:                 aka "Mauro Carvalho Chehab <mchehab@kernel.org>" [ultimate]
gpg:                 aka "Mauro Carvalho Chehab <m.chehab@samsung.com>" [ultimate]
gpg:                 aka "Mauro Carvalho Chehab <mchehab@osg.samsung.com>" [ultimate]
gpg:                 aka "Mauro Carvalho Chehab <mchehab@s-opensource.com>" [ultimate]
gpg:                 aka "Mauro Carvalho Chehab <mchehab+samsung@kernel.org>" [ultimate]
gpg:                 aka "[jpeg image of size 3594]" [ultimate]

Summary: got 3/36 patches with issues, being 1 at build time, plus one error when buinding PDF document

Error/warnings:

patches/0008-media-vidtv-add-error-checks.patch:

   checkpatch.pl:
	$ cat patches/0008-media-vidtv-add-error-checks.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:15: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)

patches/0015-media-vidtv-do-some-cleanups-at-the-driver.patch:

    allmodconfig: return code #0:
	../drivers/media/test-drivers/vidtv/vidtv_psi.c:116:12: warning: ‘vidtv_psi_pmt_get_desc_loop_len’ defined but not used [-Wunused-function]
	../drivers/media/test-drivers/vidtv/vidtv_psi.c:105:1: warning: ‘vidtv_psi_pmt_stream_get_desc_loop_len’ defined but not used [-Wunused-function]
	../drivers/media/test-drivers/vidtv/vidtv_psi.c:93:1: warning: ‘vidtv_psi_sdt_serv_get_desc_loop_len’ defined but not used [-Wunused-function]

patches/0019-media-vidtv-improve-EIT-data.patch:

   checkpatch.pl:
	$ cat patches/0019-media-vidtv-improve-EIT-data.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:27: WARNING: line length of 154 exceeds 100 columns


Error #512 when building PDF docs
pr-tracker-bot@kernel.org Nov. 27, 2020, 8:05 p.m. UTC | #2
The pull request you sent on Fri, 27 Nov 2020 13:41:00 +0100:

> git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v5.10-3

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/f594139d68ccdd64fe9c546b17189b298fa7ecd3

Thank you!