diff mbox series

[11/24] ccs: Add debug prints for MSR registers

Message ID	20201207211530.21180-12-sakari.ailus@linux.intel.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <linux-media-owner@kernel.org> From: Sakari Ailus <sakari.ailus@linux.intel.com> To: linux-media@vger.kernel.org Cc: mchehab@kernel.org Subject: [PATCH 11/24] ccs: Add debug prints for MSR registers Date: Mon, 7 Dec 2020 23:15:17 +0200 Message-Id: <20201207211530.21180-12-sakari.ailus@linux.intel.com> In-Reply-To: <20201207211530.21180-1-sakari.ailus@linux.intel.com> References: <20201207211530.21180-1-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Additional CCS feature support \| expand [00/24] Additional CCS feature support [01/24] ccs: Add digital gain support [02/24] ccs: Add support for old-style SMIA digital gain [03/24] ccs: Remove analogue gain field [04/24] ccs: Only add analogue gain control if the device supports it [05/24] v4l: uapi: Add user control base for CCS controls [06/24] Documentation: ccs: Add user documentation for the CCS driver [07/24] v4l: uapi: ccs: Add controls for analogue gain constants [08/24] ccs: Add support for analogue gain coefficient controls [09/24] v4l: uapi: ccs: Add controls for CCS alternative analogue gain [10/24] ccs: Add support for alternate analogue global gain [11/24] ccs: Add debug prints for MSR registers [12/24] v4l: uapi: ccs: Add CCS controls for shading correction [13/24] ccs: Add shading correction and luminance correction level controls [14/24] ccs: Get the endpoint by port rather than any next endpoint [15/24] ccs: Don't change the I²C address just for software reset [16/24] ccs: Only do software reset if we have no hardware reset [17/24] ccs: Wait until software reset is done [18/24] ccs: Hardware requires a delay after starting the clock of lifting reset [19/24] ccs: Add a sanity check for external clock frequency [20/24] ccs: Support and default to auto PHY control [21/24] Documentation: Include CCS PLL calculator to CCS driver documentation [22/24] ccs-pll: Switch from standard integer types to kernel ones [23/24] ccs: Switch from standard integer types to kernel ones [24/24] Revert "media: ccs-pll: Fix MODULE_LICENSE"

Commit Message

Sakari Ailus Dec. 7, 2020, 9:15 p.m. UTC

Also print out MSR registers written to the sensor. This isn't entirely
optimal as the debug strings are produced even if they're not used but
that isn't really a grave issue --- the I²C bus is very slow anyway.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/media/i2c/ccs/ccs-reg-access.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff mbox series

Patch

diff --git a/drivers/media/i2c/ccs/ccs-reg-access.c b/drivers/media/i2c/ccs/ccs-reg-access.c
index b776af2a3c33..5f0705952198 100644
--- a/drivers/media/i2c/ccs/ccs-reg-access.c
+++ b/drivers/media/i2c/ccs/ccs-reg-access.c
@@ -387,12 +387,20 @@  int ccs_write_data_regs(struct ccs_sensor *sensor, struct ccs_reg *regs,
 
 		for (j = 0; j < regs->len;
 		     j += msg.len - 2, regdata += msg.len - 2) {
+			char printbuf[(MAX_WRITE_LEN << 1) +
+				      1 /* \0 */] = { 0 };
 			int rval;
 
 			msg.len = min(regs->len - j, MAX_WRITE_LEN);
 
+			bin2hex(printbuf, regdata, msg.len);
+			dev_dbg(&client->dev,
+				"writing msr reg 0x%4.4x value 0x%s\n",
+				regs->addr + j, printbuf);
+
 			put_unaligned_be16(regs->addr + j, buf);
 			memcpy(buf + 2, regdata, msg.len);
+
 			msg.len += 2;
 
 			rval = ccs_write_retry(client, &msg);