| Message ID | 20201210134648.272857-2-maxime@cerno.tech (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/vc4: hdmi: Add CEC support for the BCM2711 | expand |
On 12/10/2020 5:46 AM, Maxime Ripard wrote: > The BCM2711 uses a number of instances of the bcmstb-l2 controller in its > display engine. Let's allow the driver to be enabled through KConfig. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Hi Maxime, On 2020-12-10 13:46, Maxime Ripard wrote: > The BCM2711 uses a number of instances of the bcmstb-l2 controller in > its > display engine. Let's allow the driver to be enabled through KConfig. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > --- > drivers/irqchip/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index c6098eee0c7c..f1e58de117dc 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -131,7 +131,7 @@ config BCM7120_L2_IRQ > select IRQ_DOMAIN > > config BRCMSTB_L2_IRQ > - bool > + bool "Broadcom STB L2 Interrupt Controller" > select GENERIC_IRQ_CHIP > select IRQ_DOMAIN I'm always sceptical of making interrupt controllers user-selectable. Who is going to know that they need to pick that one? I'd be much more in favour of directly selecting this symbol from DRM_VC4_HDMI_CEC, since there is an obvious dependency. Thanks, M.
Hi Marc, On Thu, Dec 10, 2020 at 05:59:09PM +0000, Marc Zyngier wrote: > On 2020-12-10 13:46, Maxime Ripard wrote: > > The BCM2711 uses a number of instances of the bcmstb-l2 controller in > > its > > display engine. Let's allow the driver to be enabled through KConfig. > > > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > > --- > > drivers/irqchip/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > > index c6098eee0c7c..f1e58de117dc 100644 > > --- a/drivers/irqchip/Kconfig > > +++ b/drivers/irqchip/Kconfig > > @@ -131,7 +131,7 @@ config BCM7120_L2_IRQ > > select IRQ_DOMAIN > > > > config BRCMSTB_L2_IRQ > > - bool > > + bool "Broadcom STB L2 Interrupt Controller" > > select GENERIC_IRQ_CHIP > > select IRQ_DOMAIN > > I'm always sceptical of making interrupt controllers user-selectable. > Who is going to know that they need to pick that one? > > I'd be much more in favour of directly selecting this symbol > from DRM_VC4_HDMI_CEC, since there is an obvious dependency. It's a bit weird to me that the HDMI CEC support selects it, since that interrupt controller is external and here no matter what. Would selecting it from the ARCH_* Kconfig option work for you? Thanks! Maxime
Hi Maxime, On 2020-12-14 15:27, Maxime Ripard wrote: > Hi Marc, > > On Thu, Dec 10, 2020 at 05:59:09PM +0000, Marc Zyngier wrote: [...] >> I'm always sceptical of making interrupt controllers user-selectable. >> Who is going to know that they need to pick that one? >> >> I'd be much more in favour of directly selecting this symbol >> from DRM_VC4_HDMI_CEC, since there is an obvious dependency. > > It's a bit weird to me that the HDMI CEC support selects it, since that > interrupt controller is external and here no matter what. From glancing at the series, I was under the impression that these controllers were there for the sole benefit of the HDMI controllers. Is there anything else connected to them? > Would selecting it from the ARCH_* Kconfig option work for you? Sure. My only ask is that the low level plumbing is selected without requiring any user guesswork. Thanks, M.
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index c6098eee0c7c..f1e58de117dc 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -131,7 +131,7 @@ config BCM7120_L2_IRQ select IRQ_DOMAIN config BRCMSTB_L2_IRQ - bool + bool "Broadcom STB L2 Interrupt Controller" select GENERIC_IRQ_CHIP select IRQ_DOMAIN
The BCM2711 uses a number of instances of the bcmstb-l2 controller in its display engine. Let's allow the driver to be enabled through KConfig. Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/irqchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)