diff mbox series

cma_heap: fix implicit function declaration

Message ID 20201217123053.2166511-1-siyanteng01@gmail.com (mailing list archive)
State New, archived
Headers show
Series cma_heap: fix implicit function declaration | expand

Commit Message

yanteng si Dec. 17, 2020, 12:30 p.m. UTC 
From: siyanteng <siyanteng01@gmail.com>

When building cma_heap the following error shows up:

drivers/dma-buf/heaps/cma_heap.c:195:10: error: implicit declaration of function 'vmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration]
195 |  vaddr = vmap(buffer->pages, buffer->pagecount, VM_MAP, PAGE_KERNEL);
    |          ^~~~
    |          kmap

Use this include: linux-next/include/linux/vmalloc.h

Signed-off-by: siyanteng <siyanteng01@gmail.com>
---
 drivers/dma-buf/heaps/cma_heap.c | 1 +
 1 file changed, 1 insertion(+)

Comments

John Stultz Dec. 17, 2020, 7:40 p.m. UTC | #1 
On Thu, Dec 17, 2020 at 4:31 AM <siyanteng01@gmail.com> wrote:
>
> From: siyanteng <siyanteng01@gmail.com>
>
> When building cma_heap the following error shows up:
>
> drivers/dma-buf/heaps/cma_heap.c:195:10: error: implicit declaration of function 'vmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration]
> 195 |  vaddr = vmap(buffer->pages, buffer->pagecount, VM_MAP, PAGE_KERNEL);
>     |          ^~~~
>     |          kmap
>
> Use this include: linux-next/include/linux/vmalloc.h
>
> Signed-off-by: siyanteng <siyanteng01@gmail.com>

Thanks for submitting this! My apologies for the trouble!

We already have a similar patch queued here:
  https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-next-fixes&id=8075c3005e4b1efa12dbbf6e84bc412a713de92c
so hopefully that will land upstream soon.

thanks again!
-john
diff mbox series

Patch

diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma_heap.c
index 5e7c3436310c..3c4e34301172 100644
--- a/drivers/dma-buf/heaps/cma_heap.c
+++ b/drivers/dma-buf/heaps/cma_heap.c
@@ -20,6 +20,7 @@ 
 #include <linux/module.h>
 #include <linux/scatterlist.h>
 #include <linux/slab.h>
+#include <linux/vmalloc.h>
 
 
 struct cma_heap {