From patchwork Mon Dec 28 12:17:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 11991197 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADBEDC433E0 for ; Mon, 28 Dec 2020 12:18:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 737C620897 for ; Mon, 28 Dec 2020 12:18:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727287AbgL1MSR (ORCPT ); Mon, 28 Dec 2020 07:18:17 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:58756 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726847AbgL1MSR (ORCPT ); Mon, 28 Dec 2020 07:18:17 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 749891F44439 From: Ezequiel Garcia To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel@collabora.com, Hans Verkuil , Laurent Pinchart , Ezequiel Garcia Subject: [PATCH] media: v4l2-async: Put fwnode after last access Date: Mon, 28 Dec 2020 09:17:25 -0300 Message-Id: <20201228121725.133898-1-ezequiel@collabora.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org fwnode_handle_put() should be called after the fwnode is last accessed. Fix it. Fixes: b98158d837ef ("media: v4l2-async: Accept endpoints and devices for fwnode matching") Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4l2-async.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c index e3ab003a6c85..1303c9b83138 100644 --- a/drivers/media/v4l2-core/v4l2-async.c +++ b/drivers/media/v4l2-core/v4l2-async.c @@ -78,6 +78,7 @@ static bool match_fwnode(struct v4l2_async_notifier *notifier, bool asd_fwnode_is_ep; bool sd_fwnode_is_ep; struct device *dev; + bool match; /* * Both the subdev and the async subdev can provide either an endpoint @@ -113,9 +114,10 @@ static bool match_fwnode(struct v4l2_async_notifier *notifier, other_fwnode = sd->fwnode; } - fwnode_handle_put(dev_fwnode); + match = (dev_fwnode == other_fwnode); - if (dev_fwnode != other_fwnode) + fwnode_handle_put(dev_fwnode); + if (!match) return false; /*