diff mbox series

[1/2] dt-bindings: media: Add bindings for OmniVision OV1063x sensors

Message ID 20210104053945.12409-2-laurent.pinchart@ideasonboard.com (mailing list archive)
State New
Headers show
Series media: Driver for OV1063x camera sensor | expand

Commit Message

Laurent Pinchart Jan. 4, 2021, 5:39 a.m. UTC
From: Benoit Parrot <bparrot@ti.com>

Add device tree bindings for the OmniVision OV10633 and OV10635 camera
sensors.

Signed-off-by: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 .../bindings/media/i2c/ov1063x.yaml           | 97 +++++++++++++++++++
 MAINTAINERS                                   |  7 ++
 2 files changed, 104 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ov1063x.yaml

Comments

Rob Herring Jan. 5, 2021, 5:49 p.m. UTC | #1
On Mon, Jan 04, 2021 at 07:39:44AM +0200, Laurent Pinchart wrote:
> From: Benoit Parrot <bparrot@ti.com>
> 
> Add device tree bindings for the OmniVision OV10633 and OV10635 camera
> sensors.
> 
> Signed-off-by: Benoit Parrot <bparrot@ti.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  .../bindings/media/i2c/ov1063x.yaml           | 97 +++++++++++++++++++

ovti,ov1063x.yaml

>  MAINTAINERS                                   |  7 ++
>  2 files changed, 104 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/ov1063x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov1063x.yaml b/Documentation/devicetree/bindings/media/i2c/ov1063x.yaml
> new file mode 100644
> index 000000000000..b5e08dd2f496
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ov1063x.yaml
> @@ -0,0 +1,97 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/ov1063x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OmniVision OV10633/OV1035 Camera Sensor
> +
> +maintainers:
> +  - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +
> +description: |-
> +  The OmniVision OV1063x is a 720p camera sensor which supports resolutions up
> +  to 1280x800 and 8- and 10-bit YUV output formats.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ovti,ov10633
> +      - ovti,ov10635
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clocks-names:
> +    const: xvclk
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description:
> +      Specifier for the GPIO connected to the RESETB pin.
> +
> +  powerdown-gpios:
> +    maxItems: 1
> +    description:
> +      Specifier for the GPIO connected to the PWDN pin.
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/properties/port
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: ../video-interfaces.yaml#

TBC, this patch has to go in after the above file.

Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>

> +        unevaluatedProperties: false
> +
> +        properties:
> +          hsync-active: true
> +          vsync-active: true
> +          pclk-sample: true
> +          bus-width:
> +            enum: [ 8, 10 ]
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clocks-names
> +  - port
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +        clock-frequency = <400000>;
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        camera@37 {
> +            compatible = "ovti,ov10633";
> +            reg = <0x37>;
> +
> +            clocks = <&fixed_clock>;
> +            clocks-names = "xvclk";
> +
> +            reset-gpios = <&gpio4 17 GPIO_ACTIVE_HIGH>;
> +            powerdown-gpios = <&gpio5 11 GPIO_ACTIVE_HIGH>;
> +
> +            port {
> +                camera1: endpoint {
> +                     remote-endpoint = <&vin1a_ep>;
> +                     hsync-active = <1>;
> +                     vsync-active = <1>;
> +                     pclk-sample = <0>;
> +                     bus-width = <8>;
> +                };
> +            };
> +        };
> +    };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 281de213ef47..9dc3a7d75460 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12867,6 +12867,13 @@ M:	Harald Welte <laforge@gnumonks.org>
>  S:	Maintained
>  F:	drivers/char/pcmcia/cm4040_cs.*
>  
> +OMNIVISION OV10633 SENSOR DRIVER
> +M:	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +L:	linux-media@vger.kernel.org
> +S:	Maintained
> +T:	git git://linuxtv.org/media_tree.git
> +F:	Documentation/devicetree/bindings/media/i2c/ov1063x.yaml
> +
>  OMNIVISION OV13858 SENSOR DRIVER
>  M:	Sakari Ailus <sakari.ailus@linux.intel.com>
>  L:	linux-media@vger.kernel.org
> -- 
> Regards,
> 
> Laurent Pinchart
>
Tomi Valkeinen Jan. 12, 2021, 9:31 a.m. UTC | #2
Hi Laurent,

On 04/01/2021 07:39, Laurent Pinchart wrote:
> From: Benoit Parrot <bparrot@ti.com>
> 
> Add device tree bindings for the OmniVision OV10633 and OV10635 camera
> sensors.
> 
> Signed-off-by: Benoit Parrot <bparrot@ti.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  .../bindings/media/i2c/ov1063x.yaml           | 97 +++++++++++++++++++
>  MAINTAINERS                                   |  7 ++
>  2 files changed, 104 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/ov1063x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov1063x.yaml b/Documentation/devicetree/bindings/media/i2c/ov1063x.yaml
> new file mode 100644
> index 000000000000..b5e08dd2f496
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ov1063x.yaml
> @@ -0,0 +1,97 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/ov1063x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OmniVision OV10633/OV1035 Camera Sensor
> +
> +maintainers:
> +  - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +
> +description: |-
> +  The OmniVision OV1063x is a 720p camera sensor which supports resolutions up
> +  to 1280x800 and 8- and 10-bit YUV output formats.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ovti,ov10633
> +      - ovti,ov10635
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clocks-names:

"clock-names". The same error is repeated a few times later in the patch.

 Tomi
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/ov1063x.yaml b/Documentation/devicetree/bindings/media/i2c/ov1063x.yaml
new file mode 100644
index 000000000000..b5e08dd2f496
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/ov1063x.yaml
@@ -0,0 +1,97 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/ov1063x.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: OmniVision OV10633/OV1035 Camera Sensor
+
+maintainers:
+  - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+
+description: |-
+  The OmniVision OV1063x is a 720p camera sensor which supports resolutions up
+  to 1280x800 and 8- and 10-bit YUV output formats.
+
+properties:
+  compatible:
+    enum:
+      - ovti,ov10633
+      - ovti,ov10635
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clocks-names:
+    const: xvclk
+
+  reset-gpios:
+    maxItems: 1
+    description:
+      Specifier for the GPIO connected to the RESETB pin.
+
+  powerdown-gpios:
+    maxItems: 1
+    description:
+      Specifier for the GPIO connected to the PWDN pin.
+
+  port:
+    $ref: /schemas/graph.yaml#/properties/port
+    additionalProperties: false
+
+    properties:
+      endpoint:
+        $ref: ../video-interfaces.yaml#
+        unevaluatedProperties: false
+
+        properties:
+          hsync-active: true
+          vsync-active: true
+          pclk-sample: true
+          bus-width:
+            enum: [ 8, 10 ]
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clocks-names
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    i2c {
+        clock-frequency = <400000>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        camera@37 {
+            compatible = "ovti,ov10633";
+            reg = <0x37>;
+
+            clocks = <&fixed_clock>;
+            clocks-names = "xvclk";
+
+            reset-gpios = <&gpio4 17 GPIO_ACTIVE_HIGH>;
+            powerdown-gpios = <&gpio5 11 GPIO_ACTIVE_HIGH>;
+
+            port {
+                camera1: endpoint {
+                     remote-endpoint = <&vin1a_ep>;
+                     hsync-active = <1>;
+                     vsync-active = <1>;
+                     pclk-sample = <0>;
+                     bus-width = <8>;
+                };
+            };
+        };
+    };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 281de213ef47..9dc3a7d75460 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12867,6 +12867,13 @@  M:	Harald Welte <laforge@gnumonks.org>
 S:	Maintained
 F:	drivers/char/pcmcia/cm4040_cs.*
 
+OMNIVISION OV10633 SENSOR DRIVER
+M:	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+L:	linux-media@vger.kernel.org
+S:	Maintained
+T:	git git://linuxtv.org/media_tree.git
+F:	Documentation/devicetree/bindings/media/i2c/ov1063x.yaml
+
 OMNIVISION OV13858 SENSOR DRIVER
 M:	Sakari Ailus <sakari.ailus@linux.intel.com>
 L:	linux-media@vger.kernel.org