diff mbox series

dt-bindings: media: ov5647: Fix filename

Message ID 20210115101652.9275-1-jacopo@jmondi.org (mailing list archive)
State New, archived
Headers show
Series dt-bindings: media: ov5647: Fix filename | expand

Commit Message

Jacopo Mondi Jan. 15, 2021, 10:16 a.m. UTC
Commit 1b5071af8240 ("media: dt-bindings: media: i2c: Rename
ov5647.yaml") renamed the bindings file but did not update the
Id: field there.

Fix it by using the new filename.

Fixes: 1b5071af8240 ("media: dt-bindings: media: i2c: Rename ov5647.yaml")
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.29.2

Comments

Kieran Bingham Jan. 15, 2021, 10:20 a.m. UTC | #1
Hi Jacopo,

On 15/01/2021 10:16, Jacopo Mondi wrote:
> Commit 1b5071af8240 ("media: dt-bindings: media: i2c: Rename
> ov5647.yaml") renamed the bindings file but did not update the
> Id: field there.
> 
> Fix it by using the new filename.
> 
> Fixes: 1b5071af8240 ("media: dt-bindings: media: i2c: Rename ov5647.yaml")
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

I wonder if this could be automatically validated by one of the checkers
at some point. (I assume it isn't already).

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
>  Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> index 280c62afae13..429566c9ee1d 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>  %YAML 1.2
>  ---
> -$id: http://devicetree.org/schemas/media/i2c/ov5647.yaml#
> +$id: http://devicetree.org/schemas/media/i2c/ovti,ov5647.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
> 
>  title: Omnivision OV5647 raw image sensor
> --
> 2.29.2
>
Jacopo Mondi Jan. 15, 2021, 11:01 a.m. UTC | #2
Hi Kieran

On Fri, Jan 15, 2021 at 10:20:20AM +0000, Kieran Bingham wrote:
> Hi Jacopo,
>
> On 15/01/2021 10:16, Jacopo Mondi wrote:
> > Commit 1b5071af8240 ("media: dt-bindings: media: i2c: Rename
> > ov5647.yaml") renamed the bindings file but did not update the
> > Id: field there.
> >
> > Fix it by using the new filename.
> >
> > Fixes: 1b5071af8240 ("media: dt-bindings: media: i2c: Rename ov5647.yaml")
> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
>
> I wonder if this could be automatically validated by one of the checkers
> at some point. (I assume it isn't already).
>

The dt validation process complains

../Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml: $id: relative path/filename doesn't match actual path or filename

I can't tell if it's a newly introduced validation or it was there
already when I renamed that file ~6 months ago and I failed to run
validation :/

> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> > ---
> >  Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> > index 280c62afae13..429566c9ee1d 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> > @@ -1,7 +1,7 @@
> >  # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >  %YAML 1.2
> >  ---
> > -$id: http://devicetree.org/schemas/media/i2c/ov5647.yaml#
> > +$id: http://devicetree.org/schemas/media/i2c/ovti,ov5647.yaml#
> >  $schema: http://devicetree.org/meta-schemas/core.yaml#
> >
> >  title: Omnivision OV5647 raw image sensor
> > --
> > 2.29.2
> >
>
Sakari Ailus Jan. 15, 2021, 11:04 a.m. UTC | #3
On Fri, Jan 15, 2021 at 12:01:46PM +0100, Jacopo Mondi wrote:
> Hi Kieran
> 
> On Fri, Jan 15, 2021 at 10:20:20AM +0000, Kieran Bingham wrote:
> > Hi Jacopo,
> >
> > On 15/01/2021 10:16, Jacopo Mondi wrote:
> > > Commit 1b5071af8240 ("media: dt-bindings: media: i2c: Rename
> > > ov5647.yaml") renamed the bindings file but did not update the
> > > Id: field there.
> > >
> > > Fix it by using the new filename.
> > >
> > > Fixes: 1b5071af8240 ("media: dt-bindings: media: i2c: Rename ov5647.yaml")
> > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> >
> > I wonder if this could be automatically validated by one of the checkers
> > at some point. (I assume it isn't already).
> >
> 
> The dt validation process complains
> 
> ../Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml: $id: relative path/filename doesn't match actual path or filename
> 
> I can't tell if it's a newly introduced validation or it was there
> already when I renamed that file ~6 months ago and I failed to run
> validation :/

I do run checkpatch before merging but I haven't done DT validation
regularly.
Rob Herring (Arm) Jan. 15, 2021, 3:45 p.m. UTC | #4
On Fri, Jan 15, 2021 at 11:16:52AM +0100, Jacopo Mondi wrote:
> Commit 1b5071af8240 ("media: dt-bindings: media: i2c: Rename
> ov5647.yaml") renamed the bindings file but did not update the
> Id: field there.
> 
> Fix it by using the new filename.
> 
> Fixes: 1b5071af8240 ("media: dt-bindings: media: i2c: Rename ov5647.yaml")
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>  Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Rob Herring <robh@kernel.org>

> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> index 280c62afae13..429566c9ee1d 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>  %YAML 1.2
>  ---
> -$id: http://devicetree.org/schemas/media/i2c/ov5647.yaml#
> +$id: http://devicetree.org/schemas/media/i2c/ovti,ov5647.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
> 
>  title: Omnivision OV5647 raw image sensor
> --
> 2.29.2
>
Rob Herring (Arm) Jan. 15, 2021, 3:50 p.m. UTC | #5
On Fri, Jan 15, 2021 at 12:01:46PM +0100, Jacopo Mondi wrote:
> Hi Kieran
> 
> On Fri, Jan 15, 2021 at 10:20:20AM +0000, Kieran Bingham wrote:
> > Hi Jacopo,
> >
> > On 15/01/2021 10:16, Jacopo Mondi wrote:
> > > Commit 1b5071af8240 ("media: dt-bindings: media: i2c: Rename
> > > ov5647.yaml") renamed the bindings file but did not update the
> > > Id: field there.
> > >
> > > Fix it by using the new filename.
> > >
> > > Fixes: 1b5071af8240 ("media: dt-bindings: media: i2c: Rename ov5647.yaml")
> > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> >
> > I wonder if this could be automatically validated by one of the checkers
> > at some point. (I assume it isn't already).
> >
> 
> The dt validation process complains
> 
> ../Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml: $id: relative path/filename doesn't match actual path or filename
> 
> I can't tell if it's a newly introduced validation or it was there
> already when I renamed that file ~6 months ago and I failed to run
> validation :/

It's been there since Aug 2019.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
index 280c62afae13..429566c9ee1d 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
@@ -1,7 +1,7 @@ 
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/media/i2c/ov5647.yaml#
+$id: http://devicetree.org/schemas/media/i2c/ovti,ov5647.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#

 title: Omnivision OV5647 raw image sensor