diff mbox series

drivers:staging: Simplify the if condition

Message ID 20210324054535.1716-1-tomstomsczc@163.com (mailing list archive)
State New, archived
Headers show
Series drivers:staging: Simplify the if condition | expand

Commit Message

Zhichao Cai March 24, 2021, 5:45 a.m. UTC 
From: Zhichao Cai <caizhichao@yulong.com>

Fixes coccicheck warning:
drivers/staging/media/atomisp/pci/sh_css_params.c:4652:24-26: WARNING !A || A && B is equivalent to !A || B

Signed-off-by: Zhichao Cai <caizhichao@yulong.com>
---
 drivers/staging/media/atomisp/pci/sh_css_params.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Dan Carpenter March 24, 2021, 8:20 a.m. UTC | #1 
On Wed, Mar 24, 2021 at 01:45:35PM +0800, caizhichao wrote:
> From: Zhichao Cai <caizhichao@yulong.com>
> 
> Fixes coccicheck warning:
> drivers/staging/media/atomisp/pci/sh_css_params.c:4652:24-26: WARNING !A || A && B is equivalent to !A || B
> 

Thanks, but someone already did this.  Please work against linux-next.

regards,
dan carpenter
diff mbox series

Patch

diff --git a/drivers/staging/media/atomisp/pci/sh_css_params.c b/drivers/staging/media/atomisp/pci/sh_css_params.c
index 9fad28b..7467256 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_params.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_params.c
@@ -4649,10 +4649,8 @@  struct ia_css_dvs_6axis_config *
 	params = stream->isp_params_configs;
 
 	/* Backward compatibility by default consider pipe as Video*/
-	if (!params || (params &&
-			!params->pipe_dvs_6axis_config[IA_CSS_PIPE_ID_VIDEO])) {
+	if (!params || !params->pipe_dvs_6axis_config[IA_CSS_PIPE_ID_VIDEO])
 		goto err;
-	}
 
 	dvs_config = kvcalloc(1, sizeof(struct ia_css_dvs_6axis_config),
 			      GFP_KERNEL);