diff mbox series

media: siano: use DEFINE_MUTEX() for mutex lock

Message ID 20210405205219.GA687366@LEGION (mailing list archive)
State New, archived
Headers show
Series media: siano: use DEFINE_MUTEX() for mutex lock | expand

Commit Message

Muhammad Usama Anjum April 5, 2021, 8:52 p.m. UTC 
mutex lock can be initialized with DEFINE_MUTEX() rather than
explicitly calling mutex_init().

Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
---
 drivers/media/common/siano/smscoreapi.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Comments

Muhammad Usama Anjum April 28, 2021, 4:14 p.m. UTC | #1 
Reminder!

On Tue, 2021-04-06 at 01:52 +0500, Muhammad Usama Anjum wrote:
> mutex lock can be initialized with DEFINE_MUTEX() rather than
> explicitly calling mutex_init().
> 
> Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
> ---
>  drivers/media/common/siano/smscoreapi.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/media/common/siano/smscoreapi.c b/drivers/media/common/siano/smscoreapi.c
> index 410cc3ac6f94..7f5b638d2458 100644
> --- a/drivers/media/common/siano/smscoreapi.c
> +++ b/drivers/media/common/siano/smscoreapi.c
> @@ -414,10 +414,10 @@ struct smscore_registry_entry_t {
>  
>  static struct list_head g_smscore_notifyees;
>  static struct list_head g_smscore_devices;
> -static struct mutex g_smscore_deviceslock;
> +static DEFINE_MUTEX(g_smscore_deviceslock);
>  
>  static struct list_head g_smscore_registry;
> -static struct mutex g_smscore_registrylock;
> +static DEFINE_MUTEX(g_smscore_registrylock);
>  
>  static int default_mode = DEVICE_MODE_NONE;
>  
> @@ -2123,10 +2123,7 @@ static int __init smscore_module_init(void)
>  {
>  	INIT_LIST_HEAD(&g_smscore_notifyees);
>  	INIT_LIST_HEAD(&g_smscore_devices);
> -	mutex_init(&g_smscore_deviceslock);
> -
>  	INIT_LIST_HEAD(&g_smscore_registry);
> -	mutex_init(&g_smscore_registrylock);
>  
>  	return 0;
>  }
diff mbox series

Patch

diff --git a/drivers/media/common/siano/smscoreapi.c b/drivers/media/common/siano/smscoreapi.c
index 410cc3ac6f94..7f5b638d2458 100644
--- a/drivers/media/common/siano/smscoreapi.c
+++ b/drivers/media/common/siano/smscoreapi.c
@@ -414,10 +414,10 @@  struct smscore_registry_entry_t {
 
 static struct list_head g_smscore_notifyees;
 static struct list_head g_smscore_devices;
-static struct mutex g_smscore_deviceslock;
+static DEFINE_MUTEX(g_smscore_deviceslock);
 
 static struct list_head g_smscore_registry;
-static struct mutex g_smscore_registrylock;
+static DEFINE_MUTEX(g_smscore_registrylock);
 
 static int default_mode = DEVICE_MODE_NONE;
 
@@ -2123,10 +2123,7 @@  static int __init smscore_module_init(void)
 {
 	INIT_LIST_HEAD(&g_smscore_notifyees);
 	INIT_LIST_HEAD(&g_smscore_devices);
-	mutex_init(&g_smscore_deviceslock);
-
 	INIT_LIST_HEAD(&g_smscore_registry);
-	mutex_init(&g_smscore_registrylock);
 
 	return 0;
 }