| Message ID | 20210412155959.6647-1-vrzh@vrzh.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: media: atomisp: Removed a function entry log | expand |
Hi Martiros, Thanks for the patch. On Mon, Apr 12, 2021 at 11:59:59AM -0400, Martiros Shakhzadyan wrote: > Removed a function entry log in ov2722_remove, as ftrace is a preferred > method for function entry/exit tracing. > > Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net> For this and your other atomisp patch: Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
On 12/04/2021 17:59, Martiros Shakhzadyan wrote: > Removed a function entry log in ov2722_remove, as ftrace is a preferred > method for function entry/exit tracing. It turns out that someone else already made the same fix [1], so marking this patch as obsolete. There are quite a few atomisp patches pending for 5.13, so it might be a good idea to checkout the media subsystem master tree since that is more recent than mainline. https://git.linuxtv.org/media_tree.git/ Regards, Hans [1]: https://patchwork.linuxtv.org/project/linux-media/patch/20210106181158.2270-1-fil.kolev@gmail.com/ > > Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net> > --- > drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c > index c017e9066b7a..912eadaffc44 100644 > --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c > +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c > @@ -1175,8 +1175,6 @@ static int ov2722_remove(struct i2c_client *client) > struct v4l2_subdev *sd = i2c_get_clientdata(client); > struct ov2722_device *dev = to_ov2722_sensor(sd); > > - dev_dbg(&client->dev, "ov2722_remove...\n"); > - > dev->platform_data->csi_cfg(sd, 0); > v4l2_ctrl_handler_free(&dev->ctrl_handler); > v4l2_device_unregister_subdev(sd); >
On Tue, Apr 13, 2021 at 04:51:18PM +0200, Hans Verkuil wrote: > On 12/04/2021 17:59, Martiros Shakhzadyan wrote: > > Removed a function entry log in ov2722_remove, as ftrace is a preferred > > method for function entry/exit tracing. > > It turns out that someone else already made the same fix [1], so marking > this patch as obsolete. > > There are quite a few atomisp patches pending for 5.13, so it might be > a good idea to checkout the media subsystem master tree since that is > more recent than mainline. > > https://git.linuxtv.org/media_tree.git/ > > Regards, > > Hans > > [1]: > https://patchwork.linuxtv.org/project/linux-media/patch/20210106181158.2270-1-fil.kolev@gmail.com/ > Noted. I will continue to work off of that repo - Thanks! > > > > Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net> > > --- > > drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c > > index c017e9066b7a..912eadaffc44 100644 > > --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c > > +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c > > @@ -1175,8 +1175,6 @@ static int ov2722_remove(struct i2c_client *client) > > struct v4l2_subdev *sd = i2c_get_clientdata(client); > > struct ov2722_device *dev = to_ov2722_sensor(sd); > > > > - dev_dbg(&client->dev, "ov2722_remove...\n"); > > - > > dev->platform_data->csi_cfg(sd, 0); > > v4l2_ctrl_handler_free(&dev->ctrl_handler); > > v4l2_device_unregister_subdev(sd); > > >
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c index c017e9066b7a..912eadaffc44 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c @@ -1175,8 +1175,6 @@ static int ov2722_remove(struct i2c_client *client) struct v4l2_subdev *sd = i2c_get_clientdata(client); struct ov2722_device *dev = to_ov2722_sensor(sd); - dev_dbg(&client->dev, "ov2722_remove...\n"); - dev->platform_data->csi_cfg(sd, 0); v4l2_ctrl_handler_free(&dev->ctrl_handler); v4l2_device_unregister_subdev(sd);
Removed a function entry log in ov2722_remove, as ftrace is a preferred method for function entry/exit tracing. Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net> --- drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 -- 1 file changed, 2 deletions(-)