| Message ID | 20210724195831.GA509821@pc (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | usb: stkwebcam: update the reference count of the usb device structure | expand |
On Sat, Jul 24, 2021 at 08:58:31PM +0100, Salah Triki wrote: > Use usb_get_dev() and usb_put_dev() in order to update the reference > count of the usb device structure. Why?
diff --git a/drivers/media/usb/stkwebcam/stk-webcam.c b/drivers/media/usb/stkwebcam/stk-webcam.c index a45d464427c4..3b14679829ed 100644 --- a/drivers/media/usb/stkwebcam/stk-webcam.c +++ b/drivers/media/usb/stkwebcam/stk-webcam.c @@ -1309,7 +1309,7 @@ static int stk_camera_probe(struct usb_interface *interface, init_waitqueue_head(&dev->wait_frame); dev->first_init = 1; /* webcam LED management */ - dev->udev = udev; + dev->udev = usb_get_dev(udev); dev->interface = interface; usb_get_intf(interface); @@ -1376,6 +1376,7 @@ static void stk_camera_disconnect(struct usb_interface *interface) usb_set_intfdata(interface, NULL); unset_present(dev); + usb_put_dev(interface_to_usbdev(interface)); wake_up_interruptible(&dev->wait_frame);
Use usb_get_dev() and usb_put_dev() in order to update the reference count of the usb device structure. Signed-off-by: Salah Triki <salah.triki@gmail.com> --- drivers/media/usb/stkwebcam/stk-webcam.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)