| Message ID | 20211021062547.51989-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [media] s5c73m3: Drop empty spi_driver remove callback | expand |
FTR: a.hajda@samsung.com doesn't seem to exist[1], so please don't wait for their feedback :-) Best regards Uwe [1] The MTA on mailin.samsung.com tells: Recipient address rejected: User unknown
- To: Updated Andrzej's e-mail address Quoting Uwe Kleine-König (2021-10-21 07:25:47) > A driver with a remove callback that just returns 0 behaves identically > to a driver with no remove callback at all. So simplify accordingly. Looks fine to me though. Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/media/i2c/s5c73m3/s5c73m3-spi.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c > index c102c6bbc118..7fe61187a2f8 100644 > --- a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c > +++ b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c > @@ -130,16 +130,10 @@ static int s5c73m3_spi_probe(struct spi_device *spi) > return 0; > } > > -static int s5c73m3_spi_remove(struct spi_device *spi) > -{ > - return 0; > -} > - > int s5c73m3_register_spi_driver(struct s5c73m3 *state) > { > struct spi_driver *spidrv = &state->spidrv; > > - spidrv->remove = s5c73m3_spi_remove; > spidrv->probe = s5c73m3_spi_probe; > spidrv->driver.name = S5C73M3_SPI_DRV_NAME; > spidrv->driver.of_match_table = s5c73m3_spi_ids; > -- > 2.30.2 >
On 21.10.2021 13:10, Kieran Bingham wrote: > - To: Updated Andrzej's e-mail address Thx for update :) > > Quoting Uwe Kleine-König (2021-10-21 07:25:47) >> A driver with a remove callback that just returns 0 behaves identically >> to a driver with no remove callback at all. So simplify accordingly. > Looks fine to me though. > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Regards Andrzej > >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >> --- >> drivers/media/i2c/s5c73m3/s5c73m3-spi.c | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c >> index c102c6bbc118..7fe61187a2f8 100644 >> --- a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c >> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c >> @@ -130,16 +130,10 @@ static int s5c73m3_spi_probe(struct spi_device *spi) >> return 0; >> } >> >> -static int s5c73m3_spi_remove(struct spi_device *spi) >> -{ >> - return 0; >> -} >> - >> int s5c73m3_register_spi_driver(struct s5c73m3 *state) >> { >> struct spi_driver *spidrv = &state->spidrv; >> >> - spidrv->remove = s5c73m3_spi_remove; >> spidrv->probe = s5c73m3_spi_probe; >> spidrv->driver.name = S5C73M3_SPI_DRV_NAME; >> spidrv->driver.of_match_table = s5c73m3_spi_ids; >> -- >> 2.30.2 >>
Hello Andrzej, On Thu, Oct 21, 2021 at 04:08:38PM +0200, Andrzej Hajda wrote: > > On 21.10.2021 13:10, Kieran Bingham wrote: > > - To: Updated Andrzej's e-mail address > Thx for update :) > > > Quoting Uwe Kleine-König (2021-10-21 07:25:47) > > > A driver with a remove callback that just returns 0 behaves identically > > > to a driver with no remove callback at all. So simplify accordingly. > > Looks fine to me though. > > > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Maybe it would be a sensible thing to fix your entries in MAINTAINERS? I would suggest a patch, but I don't know if s/a.hajda@samsung.com/andrzej.hajda@intel.com/ or just removing some M:-lines would be the right thing to do. Maybe a mixture?! Best regards Uwe
Quoting Uwe Kleine-König (2021-10-21 22:01:30) > Hello Andrzej, > > On Thu, Oct 21, 2021 at 04:08:38PM +0200, Andrzej Hajda wrote: > > > > On 21.10.2021 13:10, Kieran Bingham wrote: > > > - To: Updated Andrzej's e-mail address > > Thx for update :) > > > > > Quoting Uwe Kleine-K�nig (2021-10-21 07:25:47) > > > > A driver with a remove callback that just returns 0 behaves identically > > > > to a driver with no remove callback at all. So simplify accordingly. > > > Looks fine to me though. > > > > > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > > > Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> > > Maybe it would be a sensible thing to fix your entries in MAINTAINERS? I > would suggest a patch, but I don't know if > s/a.hajda@samsung.com/andrzej.hajda@intel.com/ > or just removing some M:-lines would be the right thing to do. Maybe a > mixture?! He has already sent it at [0], I saw that, and that's how I knew to update the To: after seeing your message about the bounce ;-) [0] https://lore.kernel.org/linux-media/20211018211353.586986-1-andrzej.hajda@intel.com/ -- Kieran > > Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-K�nig | > Industrial Linux Solutions | https://www.pengutronix.de/ |
diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c index c102c6bbc118..7fe61187a2f8 100644 --- a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c +++ b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c @@ -130,16 +130,10 @@ static int s5c73m3_spi_probe(struct spi_device *spi) return 0; } -static int s5c73m3_spi_remove(struct spi_device *spi) -{ - return 0; -} - int s5c73m3_register_spi_driver(struct s5c73m3 *state) { struct spi_driver *spidrv = &state->spidrv; - spidrv->remove = s5c73m3_spi_remove; spidrv->probe = s5c73m3_spi_probe; spidrv->driver.name = S5C73M3_SPI_DRV_NAME; spidrv->driver.of_match_table = s5c73m3_spi_ids;
A driver with a remove callback that just returns 0 behaves identically to a driver with no remove callback at all. So simplify accordingly. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/media/i2c/s5c73m3/s5c73m3-spi.c | 6 ------ 1 file changed, 6 deletions(-)