diff mbox series

[v2,3/4] arm64: dts: qcom: msm8916: Remove clock-lanes property from &camss node

Message ID 20211117113800.260741-4-robert.foss@linaro.org (mailing list archive)
State New, archived
Headers show
Series Remove clock-lanes DT property from CAMSS | expand

Commit Message

Robert Foss Nov. 17, 2021, 11:37 a.m. UTC
The clock-lanes property is no longer used as it is not programmable by
the CSIPHY hardware block of Qcom ISPs and should be removed.

Signed-off-by: Robert Foss <robert.foss@linaro.org>
---
 arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 2 --
 1 file changed, 2 deletions(-)

Comments

Stephan Gerhold Nov. 17, 2021, 12:41 p.m. UTC | #1
Hi Robert,

small nitpick: The subject would be more clear with
"arm64: dts: qcom: apq8016-sbc: ..." instead of "msm8916: ..." like in
your sdm845-db845c patch, since only apq8016-sbc is modified.

On Wed, Nov 17, 2021 at 12:37:59PM +0100, Robert Foss wrote:
> The clock-lanes property is no longer used as it is not programmable by
> the CSIPHY hardware block of Qcom ISPs and should be removed.
> 
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 2 --

Can you rebase this on 5.16-rc1? All of apq8016-sbc.dtsi is now in
apq8016-sbc.dts (the extra dtsi did not have any good use).

Thanks,
Stephan
Robert Foss Nov. 18, 2021, 12:03 p.m. UTC | #2
Thanks Stephan.

On Wed, 17 Nov 2021 at 13:42, Stephan Gerhold <stephan@gerhold.net> wrote:
>
> Hi Robert,
>
> small nitpick: The subject would be more clear with
> "arm64: dts: qcom: apq8016-sbc: ..." instead of "msm8916: ..." like in
> your sdm845-db845c patch, since only apq8016-sbc is modified.

Will do.

>
> On Wed, Nov 17, 2021 at 12:37:59PM +0100, Robert Foss wrote:
> > The clock-lanes property is no longer used as it is not programmable by
> > the CSIPHY hardware block of Qcom ISPs and should be removed.
> >
> > Signed-off-by: Robert Foss <robert.foss@linaro.org>
> > ---
> >  arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 2 --
>
> Can you rebase this on 5.16-rc1? All of apq8016-sbc.dtsi is now in
> apq8016-sbc.dts (the extra dtsi did not have any good use).

Ack.

>
> Thanks,
> Stephan
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index f8d8f3e3664e..faf86ce165a8 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -248,7 +248,6 @@  ports {
 		port@0 {
 			reg = <0>;
 			csiphy0_ep: endpoint {
-				clock-lanes = <1>;
 				data-lanes = <0 2>;
 				remote-endpoint = <&ov5640_ep>;
 				status = "okay";
@@ -284,7 +283,6 @@  camera_rear@3b {
 
 		port {
 			ov5640_ep: endpoint {
-				clock-lanes = <1>;
 				data-lanes = <0 2>;
 				remote-endpoint = <&csiphy0_ep>;
 			};