From patchwork Wed Dec 22 00:37:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 12690761 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2AABC43219 for ; Wed, 22 Dec 2021 00:35:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239708AbhLVAfy (ORCPT ); Tue, 21 Dec 2021 19:35:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239660AbhLVAfx (ORCPT ); Tue, 21 Dec 2021 19:35:53 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 773F9C061574 for ; Tue, 21 Dec 2021 16:35:53 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id e5so1333879wrc.5 for ; Tue, 21 Dec 2021 16:35:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rZQhtajV5OCi1ZATJjQjcnZmgKjOceV3woNx9SlMmGg=; b=lM/Ahfzh1WB5V3IlL7aA7hLyDxOE28FqB87R8MEYm54CJF1cL08x9RFcjBm+RNPcyC CAhyFnJdrog8/HPjLn/2DmBTNTM+LrurWA9EUXcm3oyITkE2s5H3L/zseq5iyXo1nfM0 KtbGQW8dFy9Fs9BHmITc7q+dx3cJ11LWDeIDi/INpbJORsgBVXM3hcqn5YW/8Pb6txJs K6idrvMQ3ZKqQUzIURbUy9ucJEcsI0bGf+MTDdNeRESEVR7QEFI2PUJ66K98s54/e8c2 +UtsqXXuiQbgEXeBSaPvyfuoM7xq+ZEGYkwNLFEcLfZrSqFkZESDZcJJOM7YgXSpsELC N//g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rZQhtajV5OCi1ZATJjQjcnZmgKjOceV3woNx9SlMmGg=; b=Kyx7ebUnGJy770FWWhRTcgw81aKeL2b9u0MMrPhP0sj3a/B3j1kGSXIuxjq7kedvq+ 3ecqfnqbbBWCa64Xf407eGxjcCs9J9aZ1SOVsiLO5fLGiBE43j5ArUaQ35Jz6j6J8tN/ hdoU7d50WBExWUt04YQVk6TPtf1Er7jmfzeXVgMD5Mr63sGSZIkX7dc/o63W1o6KI1pc Pi43+9eidJu3ZS8kLExywcL+srxp4RNh5xy+DjEl2x6CdatoWkjacyGp/fo6Zup3L1IR 49yQsgQsb2BL/xxyCPv22auIwWuYXt++WXWivNsveynJ3PspCUvuSKFeCFuq45g1yWmt kKow== X-Gm-Message-State: AOAM532Cxstgnx8H/+DRlqB+YZvEk/It91knhG5+BFNS5ccQkOU1pDq4 5mq1Wq41H+9MEEqEl+FSOO2izw== X-Google-Smtp-Source: ABdhPJwMoWwmL1a44pwH0iCAjCpKEeO1Iq5wDCwQ4ZlIL9ALAfbYMrktW4kXwJnnijJ1FYz+vxlrQg== X-Received: by 2002:a5d:4d42:: with SMTP id a2mr388013wru.311.1640133352145; Tue, 21 Dec 2021 16:35:52 -0800 (PST) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id n7sm282825wms.45.2021.12.21.16.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Dec 2021 16:35:51 -0800 (PST) From: Bryan O'Donoghue To: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, mchehab@kernel.org, hverkuil@xs4all.nl, robert.foss@linaro.org Cc: jonathan@marek.ca, andrey.konovalov@linaro.org, todor.too@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org, jgrahsl@snap.com, hfink@snap.com, vladimir.zapolskiy@linaro.org, dmitry.baryshkov@linaro.org, bryan.odonoghue@linaro.org Subject: [PATCH v3 06/19] media: camss: csid-170: don't enable unused irqs Date: Wed, 22 Dec 2021 00:37:38 +0000 Message-Id: <20211222003751.2461466-7-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211222003751.2461466-1-bryan.odonoghue@linaro.org> References: <20211222003751.2461466-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Jonathan Marek csid_isr() only checks for the reset irq, so enabling any other irqs doesn't make sense. The "RDI irq" comment is also wrong, the register should be CSID_CSI2_RDIN_IRQ_MASK. Without this fix there may be an excessive amount of irqs. Fixes: eebe6d00e9bf ("media: camss: Add support for CSID hardware version Titan 170") Signed-off-by: Jonathan Marek Reviewed-by: Robert Foss Tested-by: Julian Grahsl Tested-by: Bryan O'Donoghue Signed-off-by: Bryan O'Donoghue --- drivers/media/platform/qcom/camss/camss-csid-170.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss-csid-170.c b/drivers/media/platform/qcom/camss/camss-csid-170.c index aa65043c33037..a006c8dbceb13 100644 --- a/drivers/media/platform/qcom/camss/camss-csid-170.c +++ b/drivers/media/platform/qcom/camss/camss-csid-170.c @@ -444,12 +444,6 @@ static void csid_configure_stream(struct csid_device *csid, u8 enable) val |= 1 << CSI2_RX_CFG1_MISR_EN; writel_relaxed(val, csid->base + CSID_CSI2_RX_CFG1); // csi2_vc_mode_shift_val ? - /* error irqs start at BIT(11) */ - writel_relaxed(~0u, csid->base + CSID_CSI2_RX_IRQ_MASK); - - /* RDI irq */ - writel_relaxed(~0u, csid->base + CSID_TOP_IRQ_MASK); - val = 1 << RDI_CTRL_HALT_CMD; writel_relaxed(val, csid->base + CSID_RDI_CTRL(0)); }