| Message ID | 20220130231111.8563-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: mtk-jpeg: remove redundant initialization of variable plane_fmt | expand |
On Sun, Jan 30, 2022 at 11:11:11PM +0000, Colin Ian King wrote: > The variable plane_fmt is being initialized with a value that is never > read, it is being re-assigned a new value on each iteration of a for > loop. The initialization is redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > index f332beb06d51..b334bbb2e682 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > @@ -681,7 +681,7 @@ static int mtk_jpeg_buf_prepare(struct vb2_buffer *vb) > { > struct mtk_jpeg_ctx *ctx = vb2_get_drv_priv(vb->vb2_queue); > struct mtk_jpeg_q_data *q_data = NULL; > - struct v4l2_plane_pix_format plane_fmt = {}; > + struct v4l2_plane_pix_format plane_fmt; Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> This one is fine, but keep in mind that the other reason people do = {} assignments is to zero out struct holes. The assignment inside the loop will not do that. regards, dan carpenter
diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c index f332beb06d51..b334bbb2e682 100644 --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c @@ -681,7 +681,7 @@ static int mtk_jpeg_buf_prepare(struct vb2_buffer *vb) { struct mtk_jpeg_ctx *ctx = vb2_get_drv_priv(vb->vb2_queue); struct mtk_jpeg_q_data *q_data = NULL; - struct v4l2_plane_pix_format plane_fmt = {}; + struct v4l2_plane_pix_format plane_fmt; int i; q_data = mtk_jpeg_get_q_data(ctx, vb->vb2_queue->type);
The variable plane_fmt is being initialized with a value that is never read, it is being re-assigned a new value on each iteration of a for loop. The initialization is redundant and can be removed. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)