| Message ID | 20220301060530.5870-1-jrdr.linux@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: camss: Replace hard coded value with parameter | expand |
On Tue, 1 Mar 2022 at 07:05, Souptick Joarder <jrdr.linux@gmail.com> wrote: > > From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com> > > Kernel test robot reported below warning -> > drivers/media/platform/qcom/camss/camss-csid-gen2.c:407:3: > warning: Value stored to 'val' is never read > [clang-analyzer-deadcode.DeadStores] > > Replace hard coded value with val. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com> > --- > drivers/media/platform/qcom/camss/camss-csid-gen2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid-gen2.c b/drivers/media/platform/qcom/camss/camss-csid-gen2.c > index abbfbf448893..2031bde13a93 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid-gen2.c > +++ b/drivers/media/platform/qcom/camss/camss-csid-gen2.c > @@ -405,7 +405,7 @@ static void csid_configure_stream(struct csid_device *csid, u8 enable) > writel_relaxed(val, csid->base + CSID_RDI_FRM_DROP_PERIOD(0)); > > val = 0; > - writel_relaxed(0, csid->base + CSID_RDI_FRM_DROP_PATTERN(0)); > + writel_relaxed(val, csid->base + CSID_RDI_FRM_DROP_PATTERN(0)); > > val = 1; > writel_relaxed(val, csid->base + CSID_RDI_IRQ_SUBSAMPLE_PERIOD(0)); > -- > 2.25.1 > Reviewed-by: Robert Foss <robert.foss@linaro.org>
diff --git a/drivers/media/platform/qcom/camss/camss-csid-gen2.c b/drivers/media/platform/qcom/camss/camss-csid-gen2.c index abbfbf448893..2031bde13a93 100644 --- a/drivers/media/platform/qcom/camss/camss-csid-gen2.c +++ b/drivers/media/platform/qcom/camss/camss-csid-gen2.c @@ -405,7 +405,7 @@ static void csid_configure_stream(struct csid_device *csid, u8 enable) writel_relaxed(val, csid->base + CSID_RDI_FRM_DROP_PERIOD(0)); val = 0; - writel_relaxed(0, csid->base + CSID_RDI_FRM_DROP_PATTERN(0)); + writel_relaxed(val, csid->base + CSID_RDI_FRM_DROP_PATTERN(0)); val = 1; writel_relaxed(val, csid->base + CSID_RDI_IRQ_SUBSAMPLE_PERIOD(0));