| Message ID | 20220328195936.82552-10-nicolas.dufresne@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,01/24] media: h264: Increase reference lists size to 32 | expand |
Hey Nicolas, On 28.03.2022 15:59, Nicolas Dufresne wrote: >On -> One Hmmmm the message "One job queue already" doesn't sound correct. I think the message wants to say that the buffer is already on the queue. We could maybe enhance the message like: "Buffer already found on the job queue\n" But this is not a typo from my POV. Greetings, Sebastian > >Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> >--- > drivers/media/v4l2-core/v4l2-mem2mem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c >index 675e22895ebe..53c2332d5cbd 100644 >--- a/drivers/media/v4l2-core/v4l2-mem2mem.c >+++ b/drivers/media/v4l2-core/v4l2-mem2mem.c >@@ -316,7 +316,7 @@ static void __v4l2_m2m_try_queue(struct v4l2_m2m_dev *m2m_dev, > } > > if (m2m_ctx->job_flags & TRANS_QUEUED) { >- dprintk("On job queue already\n"); >+ dprintk("One job queue already\n"); > goto job_unlock; > } > >-- >2.34.1 >
Le mardi 29 mars 2022 à 15:57 +0200, Sebastian Fricke a écrit : > Hey Nicolas, > > On 28.03.2022 15:59, Nicolas Dufresne wrote: > > On -> One > > Hmmmm the message "One job queue already" doesn't sound correct. I think > the message wants to say that the buffer is already on the queue. > > We could maybe enhance the message like: > "Buffer already found on the job queue\n" I think I read queue -> queued. The new message would be inaccurate with this suggestion. I'll just drop that patch in V2, the fact that this message was miss-leading to me is irrelevant to the patchset. > > But this is not a typo from my POV. > > Greetings, > Sebastian > > > > > Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> > > --- > > drivers/media/v4l2-core/v4l2-mem2mem.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c > > index 675e22895ebe..53c2332d5cbd 100644 > > --- a/drivers/media/v4l2-core/v4l2-mem2mem.c > > +++ b/drivers/media/v4l2-core/v4l2-mem2mem.c > > @@ -316,7 +316,7 @@ static void __v4l2_m2m_try_queue(struct v4l2_m2m_dev *m2m_dev, > > } > > > > if (m2m_ctx->job_flags & TRANS_QUEUED) { > > - dprintk("On job queue already\n"); > > + dprintk("One job queue already\n"); > > goto job_unlock; > > } > > > > -- > > 2.34.1 > >
diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c index 675e22895ebe..53c2332d5cbd 100644 --- a/drivers/media/v4l2-core/v4l2-mem2mem.c +++ b/drivers/media/v4l2-core/v4l2-mem2mem.c @@ -316,7 +316,7 @@ static void __v4l2_m2m_try_queue(struct v4l2_m2m_dev *m2m_dev, } if (m2m_ctx->job_flags & TRANS_QUEUED) { - dprintk("On job queue already\n"); + dprintk("One job queue already\n"); goto job_unlock; }
On -> One Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> --- drivers/media/v4l2-core/v4l2-mem2mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)