From patchwork Thu Mar 31 23:11:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 12797786 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42786C433F5 for ; Thu, 31 Mar 2022 23:11:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241782AbiCaXNU (ORCPT ); Thu, 31 Mar 2022 19:13:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231195AbiCaXNT (ORCPT ); Thu, 31 Mar 2022 19:13:19 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1883137036; Thu, 31 Mar 2022 16:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=fTxX/p6obBvky64mbR0nB0OSZcvPaFGTN5Hld5X7N3E=; b=tjF3qIn/A6M6sd1qqEqQNCi2fq 8ztknsYYzhK12PH7wagGPhbiB5MZnL+k94atU3VKS7NJFiRwsYiNVTHSK1vWw5Q0FrvLUsdHnXKGM lWjHR2GoNqgpIDrHdtCNysraQHsSbSILq1BCD2ZLOJ1yQyjOQC+NTLWlCmLa4+BUP7D3nVAgyxQoU /p9zJ6/kg7kwnpnCEr/nTV5m1owfTqnvvo7VzMpfPyEshLs8YB8ZnpMJi0H2FQh0OhrFi3XEasCvB yBt8LHiE7VMBSpCMJmAgBadSsTj0+yHlxulc+kWUyAo2i9AfC0T8h4toYNZRdVbCeg7dceKSfO4Qb PlxWqRFg==; Received: from [2601:1c0:6280:3f0::aa0b] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1na3wv-003vWN-Ay; Thu, 31 Mar 2022 23:11:29 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Laurent Pinchart , Mauro Carvalho Chehab , Philipp Zabel , linux-media@vger.kernel.org Subject: [PATCH v2] media: nxp: imx-mips-csis depends on VIDEO_DEV Date: Thu, 31 Mar 2022 16:11:28 -0700 Message-Id: <20220331231128.22015-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org imx-mipi-csis uses interfaces that are made available by VIDEO_DEV, so the driver should depend on VIDEO_DEV to eliminate build errors. Fixes these build errors: aarch64-linux-ld: drivers/media/platform/nxp/imx-mipi-csis.o: in function `mipi_csis_calculate_params': imx-mipi-csis.c:(.text+0x2ec): undefined reference to `v4l2_get_link_freq' aarch64-linux-ld: drivers/media/platform/nxp/imx-mipi-csis.o: in function `mipi_csis_async_register': imx-mipi-csis.c:(.text+0x464): undefined reference to `v4l2_async_nf_init' aarch64-linux-ld: imx-mipi-csis.c:(.text+0x48c): undefined reference to `v4l2_fwnode_endpoint_parse' aarch64-linux-ld: imx-mipi-csis.c:(.text+0x538): undefined reference to `__v4l2_async_nf_add_fwnode_remote' aarch64-linux-ld: imx-mipi-csis.c:(.text+0x56c): undefined reference to `v4l2_async_subdev_nf_register' aarch64-linux-ld: imx-mipi-csis.c:(.text+0x57c): undefined reference to `v4l2_async_register_subdev' aarch64-linux-ld: drivers/media/platform/nxp/imx-mipi-csis.o: in function `mipi_csis_notify_bound': imx-mipi-csis.c:(.text+0x5e0): undefined reference to `v4l2_create_fwnode_links_to_pad' aarch64-linux-ld: drivers/media/platform/nxp/imx-mipi-csis.o: in function `mipi_csis_probe': imx-mipi-csis.c:(.text+0x1088): undefined reference to `v4l2_subdev_init' aarch64-linux-ld: imx-mipi-csis.c:(.text+0x1148): undefined reference to `v4l2_async_nf_unregister' aarch64-linux-ld: imx-mipi-csis.c:(.text+0x1150): undefined reference to `v4l2_async_nf_cleanup' aarch64-linux-ld: imx-mipi-csis.c:(.text+0x1158): undefined reference to `v4l2_async_unregister_subdev' aarch64-linux-ld: drivers/media/platform/nxp/imx-mipi-csis.o: in function `mipi_csis_set_fmt': imx-mipi-csis.c:(.text+0x1348): undefined reference to `v4l_bound_align_image' aarch64-linux-ld: drivers/media/platform/nxp/imx-mipi-csis.o: in function `mipi_csis_s_stream': imx-mipi-csis.c:(.text+0x14bc): undefined reference to `v4l2_subdev_call_wrappers' aarch64-linux-ld: imx-mipi-csis.c:(.text+0x14c0): undefined reference to `v4l2_subdev_call_wrappers' aarch64-linux-ld: imx-mipi-csis.c:(.text+0x1624): undefined reference to `v4l2_subdev_call_wrappers' aarch64-linux-ld: imx-mipi-csis.c:(.text+0x1628): undefined reference to `v4l2_subdev_call_wrappers' aarch64-linux-ld: imx-mipi-csis.c:(.text+0x16d0): undefined reference to `v4l2_subdev_call_wrappers' aarch64-linux-ld: drivers/media/platform/nxp/imx-mipi-csis.o:imx-mipi-csis.c:(.text+0x16d4): more undefined references to `v4l2_subdev_call_wrappers' follow aarch64-linux-ld: drivers/media/platform/nxp/imx-mipi-csis.o: in function `mipi_csis_remove': aarch64-linux-ld: drivers/media/platform/nxp/imx-mipi-csis.o:(.rodata+0x4b8): undefined reference to `v4l2_subdev_get_fwnode_pad_1_to_1' aarch64-linux-ld: drivers/media/platform/nxp/imx-mipi-csis.o:(.rodata+0x4c8): undefined reference to `v4l2_subdev_link_validate' Fixes: 46fb99951fe2 ("media: platform: place NXP drivers on a separate dir") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Philipp Zabel Cc: linux-media@vger.kernel.org --- v2: fix copy-pasta Subject: line problem drivers/media/platform/nxp/Kconfig | 1 + 1 file changed, 1 insertion(+) --- linux-next-20220331.orig/drivers/media/platform/nxp/Kconfig +++ linux-next-20220331/drivers/media/platform/nxp/Kconfig @@ -7,6 +7,7 @@ comment "NXP media platform drivers" config VIDEO_IMX_MIPI_CSIS tristate "NXP MIPI CSI-2 CSIS receiver found on i.MX7 and i.MX8 models" depends on ARCH_MXC || COMPILE_TEST + depends on VIDEO_DEV select MEDIA_CONTROLLER select V4L2_FWNODE select VIDEO_V4L2_SUBDEV_API