| Message ID | 20220412105156.17091-1-ming.qian@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: amphion: fix decoder's interlaced filed | expand |
Hi Ming, In Subject: s/filed/field On Tue, Apr 12, 2022 at 7:52 AM Ming Qian <ming.qian@nxp.com> wrote: > > For interlaced frame, the amphion vpu will store the > two fileds sequential into one buffer, top-bottom order s/fileds/fields > so the filed should be set to V4L2_FIELD_SEQ_TB. s/filed/field > fix the previous bug that setting it to V4L2_FIELD_SEQ_BT wrongly. s/setting/set Do you need to pass a Fixes tag too?
Hi Fabio,
Thank you for your reminder
> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@gmail.com]
> Sent: Tuesday, April 12, 2022 6:55 PM
> To: Ming Qian <ming.qian@nxp.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Shawn Guo
> <shawnguo@kernel.org>; Hans Verkuil <hverkuil-cisco@xs4all.nl>; Rob Herring
> <robh+dt@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>; Sascha
> Hauer <kernel@pengutronix.de>; dl-linux-imx <linux-imx@nxp.com>; Aisheng
> Dong <aisheng.dong@nxp.com>; linux-media <linux-media@vger.kernel.org>;
> linux-kernel <linux-kernel@vger.kernel.org>; moderated list:ARM/FREESCALE
> IMX / MXC ARM ARCHITECTURE <linux-arm-kernel@lists.infradead.org>
> Subject: [EXT] Re: [PATCH] media: amphion: fix decoder's interlaced filed
>
> Caution: EXT Email
>
> Hi Ming,
>
> In Subject: s/filed/field
>
> On Tue, Apr 12, 2022 at 7:52 AM Ming Qian <ming.qian@nxp.com> wrote:
> >
> > For interlaced frame, the amphion vpu will store the two fileds
> > sequential into one buffer, top-bottom order
>
> s/fileds/fields
>
> > so the filed should be set to V4L2_FIELD_SEQ_TB.
>
> s/filed/field
>
> > fix the previous bug that setting it to V4L2_FIELD_SEQ_BT wrongly.
>
> s/setting/set
>
> Do you need to pass a Fixes tag too?
diff --git a/drivers/media/platform/amphion/vdec.c b/drivers/media/platform/amphion/vdec.c index 09628dd0c855..0a1976852b0d 100644 --- a/drivers/media/platform/amphion/vdec.c +++ b/drivers/media/platform/amphion/vdec.c @@ -804,7 +804,7 @@ static void vdec_init_fmt(struct vpu_inst *inst) if (vdec->codec_info.progressive) inst->cap_format.field = V4L2_FIELD_NONE; else - inst->cap_format.field = V4L2_FIELD_SEQ_BT; + inst->cap_format.field = V4L2_FIELD_SEQ_TB; if (vdec->codec_info.color_primaries == V4L2_COLORSPACE_DEFAULT) vdec->codec_info.color_primaries = V4L2_COLORSPACE_REC709; if (vdec->codec_info.transfer_chars == V4L2_XFER_FUNC_DEFAULT)
For interlaced frame, the amphion vpu will store the two fileds sequential into one buffer, top-bottom order so the filed should be set to V4L2_FIELD_SEQ_TB. fix the previous bug that setting it to V4L2_FIELD_SEQ_BT wrongly. Signed-off-by: Ming Qian <ming.qian@nxp.com> --- drivers/media/platform/amphion/vdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)