diff mbox series

[PATCHv2,2/4] igorplugusb: prevent use after free in probe error

Message ID 20220512123723.25815-2-oneukum@suse.com (mailing list archive)
State New, archived
Headers show
Series [PATCHv2,1/4] igorplugusb: respect DMA coherency | expand

Commit Message

Oliver Neukum May 12, 2022, 12:37 p.m. UTC 
The timer uses the URB. Free it only after the timer
has been stopped.

v2: Resending series due to omitting first patch
Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
 drivers/media/rc/igorplugusb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/media/rc/igorplugusb.c b/drivers/media/rc/igorplugusb.c
index b46362da8623..1afba95409ff 100644
--- a/drivers/media/rc/igorplugusb.c
+++ b/drivers/media/rc/igorplugusb.c
@@ -223,9 +223,9 @@  static int igorplugusb_probe(struct usb_interface *intf,
 
 	return 0;
 fail:
-	rc_free_device(ir->rc);
-	usb_free_urb(ir->urb);
 	del_timer(&ir->timer);
+	usb_free_urb(ir->urb);
+	rc_free_device(ir->rc);
 	kfree(ir->buf_in);
 
 	return ret;