| Message ID | 20220708084459.7472-1-marko.makela@iki.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: lirc: ensure lirc device receives repeats | expand |
On Fri, Jul 08, 2022 at 11:44:59AM +0300, Marko Mäkelä wrote: > Pressing a button on a remote control unit will typically lead to > messages being sent several times per second until the button is released. > > Some remote control units indicate long key presses by sending > special "repeat" messages, for which the protocol driver calls > rc_repeat(). Other units repeat the same message over and over, > which will be handled by calling rc_keydown(). > > The function rc_keydown() never set the LIRC "repeat" flag to distinguish > repeated messages that were sent due to a long keypress, and messages > sent due to repeated short keypresses. While a user-space program may > implement special logic to distinguish long keypresses, it is much simpler > to be able to rely on the flag. > > Commit de142c32410649e64d44928505ffad2176a96a9e ("media: lirc: implement > reading scancode") would never set the LIRC_SCANCODE_FLAG_REPEAT flag. > Commit b66218fddfd29f315a103db811152ab0c95fb054 > ("media: lirc: ensure lirc device receives nec repeats") fixed it up for > rc_repeat() but not rc_keydown(). Perfect, thanks. Sean > > Signed-off-by: Marko Mäkelä <marko.makela@iki.fi> > Co-developed-by: Sean Young <sean@mess.org> > --- > drivers/media/rc/rc-main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c > index b90438a71c80..d914197245eb 100644 > --- a/drivers/media/rc/rc-main.c > +++ b/drivers/media/rc/rc-main.c > @@ -786,7 +786,8 @@ static void ir_do_keydown(struct rc_dev *dev, enum rc_proto protocol, > dev->last_toggle != toggle); > struct lirc_scancode sc = { > .scancode = scancode, .rc_proto = protocol, > - .flags = toggle ? LIRC_SCANCODE_FLAG_TOGGLE : 0, > + .flags = (toggle ? LIRC_SCANCODE_FLAG_TOGGLE : 0) | > + (!new_event ? LIRC_SCANCODE_FLAG_REPEAT : 0), > .keycode = keycode > }; > > -- > 2.36.1
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index b90438a71c80..d914197245eb 100644 --- a/drivers/media/rc/rc-main.c +++ b/drivers/media/rc/rc-main.c @@ -786,7 +786,8 @@ static void ir_do_keydown(struct rc_dev *dev, enum rc_proto protocol, dev->last_toggle != toggle); struct lirc_scancode sc = { .scancode = scancode, .rc_proto = protocol, - .flags = toggle ? LIRC_SCANCODE_FLAG_TOGGLE : 0, + .flags = (toggle ? LIRC_SCANCODE_FLAG_TOGGLE : 0) | + (!new_event ? LIRC_SCANCODE_FLAG_REPEAT : 0), .keycode = keycode };
Pressing a button on a remote control unit will typically lead to messages being sent several times per second until the button is released. Some remote control units indicate long key presses by sending special "repeat" messages, for which the protocol driver calls rc_repeat(). Other units repeat the same message over and over, which will be handled by calling rc_keydown(). The function rc_keydown() never set the LIRC "repeat" flag to distinguish repeated messages that were sent due to a long keypress, and messages sent due to repeated short keypresses. While a user-space program may implement special logic to distinguish long keypresses, it is much simpler to be able to rely on the flag. Commit de142c32410649e64d44928505ffad2176a96a9e ("media: lirc: implement reading scancode") would never set the LIRC_SCANCODE_FLAG_REPEAT flag. Commit b66218fddfd29f315a103db811152ab0c95fb054 ("media: lirc: ensure lirc device receives nec repeats") fixed it up for rc_repeat() but not rc_keydown(). Signed-off-by: Marko Mäkelä <marko.makela@iki.fi> Co-developed-by: Sean Young <sean@mess.org> --- drivers/media/rc/rc-main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)