| Message ID | 20220718014215.1240114-4-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add imx577 compatible to imx412 | expand |
diff --git a/drivers/media/i2c/imx577.c b/drivers/media/i2c/imx577.c index 519b523c4091..e9b381e067db 100644 --- a/drivers/media/i2c/imx577.c +++ b/drivers/media/i2c/imx577.c @@ -27,7 +27,7 @@ /* Chip ID */ #define IMX577_REG_ID 0x0016 -#define IMX577_ID 0x577 +#define IMX577_CHIP_ID 0x577 /* Exposure control */ #define IMX577_REG_EXPOSURE_CIT 0x0202 @@ -904,9 +904,9 @@ static int imx577_detect(struct imx577 *imx577) if (ret) return ret; - if (val != IMX577_ID) { + if (val != IMX577_CHIP_ID) { dev_err(imx577->dev, "chip id mismatch: %x!=%x", - IMX577_ID, val); + IMX577_CHIP_ID, val); return -ENXIO; }
Other IMX chips which read out the chip-id @ 0x0016 use the following naming convention drivers/media/i2c/imx258.c:#define IMX258_CHIP_ID 0x0258 drivers/media/i2c/imx319.c:#define IMX319_CHIP_ID 0x0319 drivers/media/i2c/imx355.c:#define IMX355_CHIP_ID 0x0355 Right now imx577.c does drivers/media/i2c/imx577.c:#define IMX577_ID 0x577 Fixup the define name for consistency to IMX577_CHIP_ID. Fixes: 9214e86c0cc1 ("media: i2c: Add imx412 camera sensor driver") Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- drivers/media/i2c/imx577.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)