| Message ID | 20220802093219.30599-1-contact@emersion.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | edid-decode: downgrade missing display product name to warning | expand |
On 8/2/22 11:32, Simon Ser wrote: > The spec says: > >> The model name of the display product may be listed (optional >> but recommended) in the Display Product Name (ASCII) String >> Descriptor (tag #FCh). > > So a missing Display Product Name descriptor shouldn't fail > conformance. Actually it is mandatory in EDID v1.3, but optional for EDID v1.4. So this should be a fail if edid_minor == 3, and a warn otherwise. Can you post a v2 of this patch? You can use the msg() function directly instead of fail/warn. Regards, Hans > > Signed-off-by: Simon Ser <contact@emersion.fr> > --- > parse-base-block.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/parse-base-block.cpp b/parse-base-block.cpp > index 9644577bab70..525cd4c02257 100644 > --- a/parse-base-block.cpp > +++ b/parse-base-block.cpp > @@ -1673,7 +1673,7 @@ void edid_state::parse_base_block(const unsigned char *x) > do_checksum("", x, EDID_PAGE_SIZE); > if (base.edid_minor >= 3) { > if (!base.has_name_descriptor) > - fail("Missing Display Product Name.\n"); > + warn("Missing Display Product Name.\n"); > if ((base.edid_minor == 3 || base.supports_continuous_freq) && > !base.has_display_range_descriptor) > fail("Missing Display Range Limits Descriptor.\n"); > > base-commit: 582c935652b0303b87ddad4551e6f97f8bb883ac
diff --git a/parse-base-block.cpp b/parse-base-block.cpp index 9644577bab70..525cd4c02257 100644 --- a/parse-base-block.cpp +++ b/parse-base-block.cpp @@ -1673,7 +1673,7 @@ void edid_state::parse_base_block(const unsigned char *x) do_checksum("", x, EDID_PAGE_SIZE); if (base.edid_minor >= 3) { if (!base.has_name_descriptor) - fail("Missing Display Product Name.\n"); + warn("Missing Display Product Name.\n"); if ((base.edid_minor == 3 || base.supports_continuous_freq) && !base.has_display_range_descriptor) fail("Missing Display Range Limits Descriptor.\n");