diff mbox series

[v2] edid-decode: downgrade missing display product name to warning

Message ID 20220802132613.47141-1-contact@emersion.fr (mailing list archive)
State New, archived
Headers show
Series [v2] edid-decode: downgrade missing display product name to warning | expand

Commit Message

Simon Ser Aug. 2, 2022, 1:26 p.m. UTC 
The E-EDID 1.4 spec says:

> The model name of the display product may be listed (optional
> but recommended) in the Display Product Name (ASCII) String
> Descriptor (tag #FCh).

So a missing Display Product Name descriptor shouldn't fail
conformance.

E-EDID 1.3 still requires the monitor name, so keep failing in
that case.

Signed-off-by: Simon Ser <contact@emersion.fr>
---

v2: keep this a failure for EDID 1.3

 parse-base-block.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 582c935652b0303b87ddad4551e6f97f8bb883ac
diff mbox series

Patch

diff --git a/parse-base-block.cpp b/parse-base-block.cpp
index 9644577bab70..a27505abec98 100644
--- a/parse-base-block.cpp
+++ b/parse-base-block.cpp
@@ -1673,7 +1673,7 @@  void edid_state::parse_base_block(const unsigned char *x)
 	do_checksum("", x, EDID_PAGE_SIZE);
 	if (base.edid_minor >= 3) {
 		if (!base.has_name_descriptor)
-			fail("Missing Display Product Name.\n");
+			msg(base.edid_minor >= 4, "Missing Display Product Name.\n");
 		if ((base.edid_minor == 3 || base.supports_continuous_freq) &&
 		    !base.has_display_range_descriptor)
 			fail("Missing Display Range Limits Descriptor.\n");