| Message ID | 20220911091519.3212868-3-cuigaosheng1@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Remove unused declarations for media | expand |
Quoting Gaosheng Cui (2022-09-11 10:15:13) > vsp1_subdev_internal_ops has been removed since > commit 0efdf0f5eaaf ("[media] v4l: vsp1: Implement and use the > subdev pad::init_cfg configuration"), so remove it. > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> It does look lonely indeed. Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/media/platform/renesas/vsp1/vsp1_entity.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/platform/renesas/vsp1/vsp1_entity.h b/drivers/media/platform/renesas/vsp1/vsp1_entity.h > index f22724439cdc..17f98a6a972e 100644 > --- a/drivers/media/platform/renesas/vsp1/vsp1_entity.h > +++ b/drivers/media/platform/renesas/vsp1/vsp1_entity.h > @@ -130,8 +130,6 @@ int vsp1_entity_init(struct vsp1_device *vsp1, struct vsp1_entity *entity, > const struct v4l2_subdev_ops *ops, u32 function); > void vsp1_entity_destroy(struct vsp1_entity *entity); > > -extern const struct v4l2_subdev_internal_ops vsp1_subdev_internal_ops; > - > int vsp1_entity_link_setup(struct media_entity *entity, > const struct media_pad *local, > const struct media_pad *remote, u32 flags); > -- > 2.25.1 >
On Sun, Sep 11, 2022 at 02:38:19PM +0100, Kieran Bingham wrote: > Quoting Gaosheng Cui (2022-09-11 10:15:13) > > vsp1_subdev_internal_ops has been removed since > > commit 0efdf0f5eaaf ("[media] v4l: vsp1: Implement and use the > > subdev pad::init_cfg configuration"), so remove it. > > > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > > It does look lonely indeed. > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> The subject line should start with "media: platform: vsp1:". I'll fix this when applying. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > drivers/media/platform/renesas/vsp1/vsp1_entity.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/media/platform/renesas/vsp1/vsp1_entity.h b/drivers/media/platform/renesas/vsp1/vsp1_entity.h > > index f22724439cdc..17f98a6a972e 100644 > > --- a/drivers/media/platform/renesas/vsp1/vsp1_entity.h > > +++ b/drivers/media/platform/renesas/vsp1/vsp1_entity.h > > @@ -130,8 +130,6 @@ int vsp1_entity_init(struct vsp1_device *vsp1, struct vsp1_entity *entity, > > const struct v4l2_subdev_ops *ops, u32 function); > > void vsp1_entity_destroy(struct vsp1_entity *entity); > > > > -extern const struct v4l2_subdev_internal_ops vsp1_subdev_internal_ops; > > - > > int vsp1_entity_link_setup(struct media_entity *entity, > > const struct media_pad *local, > > const struct media_pad *remote, u32 flags);
diff --git a/drivers/media/platform/renesas/vsp1/vsp1_entity.h b/drivers/media/platform/renesas/vsp1/vsp1_entity.h index f22724439cdc..17f98a6a972e 100644 --- a/drivers/media/platform/renesas/vsp1/vsp1_entity.h +++ b/drivers/media/platform/renesas/vsp1/vsp1_entity.h @@ -130,8 +130,6 @@ int vsp1_entity_init(struct vsp1_device *vsp1, struct vsp1_entity *entity, const struct v4l2_subdev_ops *ops, u32 function); void vsp1_entity_destroy(struct vsp1_entity *entity); -extern const struct v4l2_subdev_internal_ops vsp1_subdev_internal_ops; - int vsp1_entity_link_setup(struct media_entity *entity, const struct media_pad *local, const struct media_pad *remote, u32 flags);
vsp1_subdev_internal_ops has been removed since commit 0efdf0f5eaaf ("[media] v4l: vsp1: Implement and use the subdev pad::init_cfg configuration"), so remove it. Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> --- drivers/media/platform/renesas/vsp1/vsp1_entity.h | 2 -- 1 file changed, 2 deletions(-)