| Message ID | 20220915150324.688062-2-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: Switch to use dev_err_probe() helper | expand |
Hi Yang, Thank you for the patch. On Thu, Sep 15, 2022 at 11:03:12PM +0800, Yang Yingliang wrote: > In the probe path, dev_err() can be replace with dev_err_probe() > which will check if error code is -EPROBE_DEFER. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/cec/platform/stm32/stm32-cec.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/cec/platform/stm32/stm32-cec.c b/drivers/media/cec/platform/stm32/stm32-cec.c > index 40db7911b437..7b2db46a5722 100644 > --- a/drivers/media/cec/platform/stm32/stm32-cec.c > +++ b/drivers/media/cec/platform/stm32/stm32-cec.c > @@ -288,12 +288,9 @@ static int stm32_cec_probe(struct platform_device *pdev) > return ret; > > cec->clk_cec = devm_clk_get(&pdev->dev, "cec"); > - if (IS_ERR(cec->clk_cec)) { > - if (PTR_ERR(cec->clk_cec) != -EPROBE_DEFER) > - dev_err(&pdev->dev, "Cannot get cec clock\n"); > - > - return PTR_ERR(cec->clk_cec); > - } > + if (IS_ERR(cec->clk_cec)) > + return dev_err_probe(&pdev->dev, PTR_ERR(cec->clk_cec), > + "Cannot get cec clock\n"); > > ret = clk_prepare(cec->clk_cec); > if (ret) {
diff --git a/drivers/media/cec/platform/stm32/stm32-cec.c b/drivers/media/cec/platform/stm32/stm32-cec.c index 40db7911b437..7b2db46a5722 100644 --- a/drivers/media/cec/platform/stm32/stm32-cec.c +++ b/drivers/media/cec/platform/stm32/stm32-cec.c @@ -288,12 +288,9 @@ static int stm32_cec_probe(struct platform_device *pdev) return ret; cec->clk_cec = devm_clk_get(&pdev->dev, "cec"); - if (IS_ERR(cec->clk_cec)) { - if (PTR_ERR(cec->clk_cec) != -EPROBE_DEFER) - dev_err(&pdev->dev, "Cannot get cec clock\n"); - - return PTR_ERR(cec->clk_cec); - } + if (IS_ERR(cec->clk_cec)) + return dev_err_probe(&pdev->dev, PTR_ERR(cec->clk_cec), + "Cannot get cec clock\n"); ret = clk_prepare(cec->clk_cec); if (ret) {
In the probe path, dev_err() can be replace with dev_err_probe() which will check if error code is -EPROBE_DEFER. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/media/cec/platform/stm32/stm32-cec.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)