diff mbox series

edid-decode: fix clock step for CVT RBv3

Message ID 20221005121221.14882-1-contact@emersion.fr (mailing list archive)
State New, archived
Headers show
Series edid-decode: fix clock step for CVT RBv3 | expand

Commit Message

Simon Ser Oct. 5, 2022, 12:12 p.m. UTC
According to CVT 2.0 table 3-2, C_CLOCK_STEP = 0.001 for both
RBv2 and RBv3.

Signed-off-by: Simon Ser <contact@emersion.fr>
---
 calc-gtf-cvt.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hans Verkuil Oct. 6, 2022, 1:46 p.m. UTC | #1
Hi Simon,

On 10/5/22 14:12, Simon Ser wrote:
> According to CVT 2.0 table 3-2, C_CLOCK_STEP = 0.001 for both
> RBv2 and RBv3.

Another nice catch!

Thank you,

	Hans

> 
> Signed-off-by: Simon Ser <contact@emersion.fr>
> ---
>  calc-gtf-cvt.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/calc-gtf-cvt.cpp b/calc-gtf-cvt.cpp
> index dc22ad535135..6330bb7ac814 100644
> --- a/calc-gtf-cvt.cpp
> +++ b/calc-gtf-cvt.cpp
> @@ -152,7 +152,7 @@ timings edid_state::calc_cvt_mode(unsigned h_pixels, unsigned v_lines,
>  	double interlace = int_rqd ? 0.5 : 0;
>  	double total_active_pixels = h_pixels_rnd + hor_margin * 2;
>  	double v_field_rate_rqd = int_rqd ? ip_freq_rqd * 2 : ip_freq_rqd;
> -	double clock_step = rb == RB_CVT_V2 ? 0.001 : 0.25;
> +	double clock_step = rb >= RB_CVT_V2 ? 0.001 : 0.25;
>  	double h_blank = (rb == RB_CVT_V1 || (rb == RB_CVT_V3 && alt)) ? 160 : 80;
>  	double rb_v_fporch = rb == RB_CVT_V1 ? 3 : 1;
>  	double refresh_multiplier = (rb == RB_CVT_V2 && alt) ? 1000.0 / 1001.0 : 1;
diff mbox series

Patch

diff --git a/calc-gtf-cvt.cpp b/calc-gtf-cvt.cpp
index dc22ad535135..6330bb7ac814 100644
--- a/calc-gtf-cvt.cpp
+++ b/calc-gtf-cvt.cpp
@@ -152,7 +152,7 @@  timings edid_state::calc_cvt_mode(unsigned h_pixels, unsigned v_lines,
 	double interlace = int_rqd ? 0.5 : 0;
 	double total_active_pixels = h_pixels_rnd + hor_margin * 2;
 	double v_field_rate_rqd = int_rqd ? ip_freq_rqd * 2 : ip_freq_rqd;
-	double clock_step = rb == RB_CVT_V2 ? 0.001 : 0.25;
+	double clock_step = rb >= RB_CVT_V2 ? 0.001 : 0.25;
 	double h_blank = (rb == RB_CVT_V1 || (rb == RB_CVT_V3 && alt)) ? 160 : 80;
 	double rb_v_fporch = rb == RB_CVT_V1 ? 3 : 1;
 	double refresh_multiplier = (rb == RB_CVT_V2 && alt) ? 1000.0 / 1001.0 : 1;