diff mbox series

media: i2c: adv748x: Remove dead function declaration

Message ID 20221008141205.3493964-1-niklas.soderlund+renesas@ragnatech.se (mailing list archive)
State New, archived
Headers show
Series media: i2c: adv748x: Remove dead function declaration | expand

Commit Message

Niklas Söderlund Oct. 8, 2022, 2:12 p.m. UTC 
There is no implementation of adv748x_register_subdevs(), remove the
declaration in the header file.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 drivers/media/i2c/adv748x/adv748x.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Wolfram Sang Oct. 9, 2022, 9:23 p.m. UTC | #1 
On Sat, Oct 08, 2022 at 04:12:05PM +0200, Niklas Söderlund wrote:
> There is no implementation of adv748x_register_subdevs(), remove the
> declaration in the header file.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

True.

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Kieran Bingham Oct. 10, 2022, 8:51 a.m. UTC | #2 
Quoting Niklas Söderlund (2022-10-08 15:12:05)
> There is no implementation of adv748x_register_subdevs(), remove the
> declaration in the header file.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
>  drivers/media/i2c/adv748x/adv748x.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/adv748x/adv748x.h b/drivers/media/i2c/adv748x/adv748x.h
> index d75eb3d8be5a..6f90f78f58cf 100644
> --- a/drivers/media/i2c/adv748x/adv748x.h
> +++ b/drivers/media/i2c/adv748x/adv748x.h
> @@ -428,9 +428,6 @@ void adv748x_subdev_init(struct v4l2_subdev *sd, struct adv748x_state *state,
>                          const struct v4l2_subdev_ops *ops, u32 function,
>                          const char *ident);
>  
> -int adv748x_register_subdevs(struct adv748x_state *state,
> -                            struct v4l2_device *v4l2_dev);
> -
>  int adv748x_tx_power(struct adv748x_csi2 *tx, bool on);
>  
>  int adv748x_afe_init(struct adv748x_afe *afe);
> -- 
> 2.37.3
>
diff mbox series

Patch

diff --git a/drivers/media/i2c/adv748x/adv748x.h b/drivers/media/i2c/adv748x/adv748x.h
index d75eb3d8be5a..6f90f78f58cf 100644
--- a/drivers/media/i2c/adv748x/adv748x.h
+++ b/drivers/media/i2c/adv748x/adv748x.h
@@ -428,9 +428,6 @@  void adv748x_subdev_init(struct v4l2_subdev *sd, struct adv748x_state *state,
 			 const struct v4l2_subdev_ops *ops, u32 function,
 			 const char *ident);
 
-int adv748x_register_subdevs(struct adv748x_state *state,
-			     struct v4l2_device *v4l2_dev);
-
 int adv748x_tx_power(struct adv748x_csi2 *tx, bool on);
 
 int adv748x_afe_init(struct adv748x_afe *afe);