| Message ID | 20221109073529.26765-2-yunfei.dong@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] media: dt-bindings: media: mediatek: vcodec: Fix clock num not correctly | expand |
Il 09/11/22 08:35, Yunfei Dong ha scritto: > Need to add racing control register base in device node for mt8195 support > inner racing mode. Changing the max reg value from 1 to 2. > > Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com> > --- > .../bindings/media/mediatek,vcodec-subdev-decoder.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml > index 794012853834..1697feb1f854 100644 > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml > @@ -61,7 +61,7 @@ properties: > - mediatek,mt8195-vcodec-dec > > reg: > - maxItems: 1 > + maxItems: 2 What about doing, instead... - description: VDEC_SYS register space - description: VDEC_RACING_CTRL register space then, setting `minItems: 1` will make the racing_ctrl iospace optional :-) Regards, Angelo
On Wed, 09 Nov 2022 15:35:28 +0800, Yunfei Dong wrote: > Need to add racing control register base in device node for mt8195 support > inner racing mode. Changing the max reg value from 1 to 2. > > Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com> > --- > .../bindings/media/mediatek,vcodec-subdev-decoder.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.example.dtb: video-codec@16000000: reg: [[0, 369098752, 0, 4096]] is too short From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Dear AngeloGioacchino Del, Thank for your suggestion, looks very reasonable. Fix in v2. Best regards, Yunfei Dong On Wed, 2022-11-09 at 10:29 +0100, AngeloGioacchino Del Regno wrote: > Il 09/11/22 08:35, Yunfei Dong ha scritto: > > Need to add racing control register base in device node for mt8195 > > support > > inner racing mode. Changing the max reg value from 1 to 2. > > > > Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com> > > --- > > .../bindings/media/mediatek,vcodec-subdev-decoder.yaml | > > 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev- > > decoder.yaml > > b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev- > > decoder.yaml > > index 794012853834..1697feb1f854 100644 > > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec- > > subdev-decoder.yaml > > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec- > > subdev-decoder.yaml > > @@ -61,7 +61,7 @@ properties: > > - mediatek,mt8195-vcodec-dec > > > > reg: > > - maxItems: 1 > > + maxItems: 2 > > What about doing, instead... > > - description: VDEC_SYS register space > - description: VDEC_RACING_CTRL register space > > then, setting `minItems: 1` will make the racing_ctrl iospace > optional :-) > > Regards, > Angelo > >
Hi Rob, Thanks for your comments, already fixed in patch v2. Best Regards, Yunfei Dong On Wed, 2022-11-09 at 06:59 -0600, Rob Herring wrote: > On Wed, 09 Nov 2022 15:35:28 +0800, Yunfei Dong wrote: > > Need to add racing control register base in device node for mt8195 > > support > > inner racing mode. Changing the max reg value from 1 to 2. > > > > Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com> > > --- > > .../bindings/media/mediatek,vcodec-subdev-decoder.yaml | > > 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m > dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review- > ci/linux/Documentation/devicetree/bindings/media/mediatek,vcodec- > subdev-decoder.example.dtb: video-codec@16000000: reg: [[0, > 369098752, 0, 4096]] is too short > From schema: /builds/robherring/dt-review- > ci/linux/Documentation/devicetree/bindings/media/mediatek,vcodec- > subdev-decoder.yaml > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/ > > This check can fail if there are any dependencies. The base for a > patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up > to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > >
diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml index 794012853834..1697feb1f854 100644 --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml @@ -61,7 +61,7 @@ properties: - mediatek,mt8195-vcodec-dec reg: - maxItems: 1 + maxItems: 2 iommus: minItems: 1
Need to add racing control register base in device node for mt8195 support inner racing mode. Changing the max reg value from 1 to 2. Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com> --- .../bindings/media/mediatek,vcodec-subdev-decoder.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)