| Message ID | 20221117-b4-amlogic-bindings-convert-v1-2-3f025599b968@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: first batch of dt-schema conversions for Amlogic Meson bindings | expand |
On 18/11/2022 15:33, Neil Armstrong wrote: > Convert the Amlogic Meson GX eFuse bindings to dt-schema. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > .../bindings/nvmem/amlogic,meson-gxbb-efuse.yaml | 52 ++++++++++++++++++++++ > .../devicetree/bindings/nvmem/amlogic-efuse.txt | 48 -------------------- > 2 files changed, 52 insertions(+), 48 deletions(-) > > diff --git a/Documentation/devicetree/bindings/nvmem/amlogic,meson-gxbb-efuse.yaml b/Documentation/devicetree/bindings/nvmem/amlogic,meson-gxbb-efuse.yaml > new file mode 100644 > index 000000000000..1d88f7eee840 > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/amlogic,meson-gxbb-efuse.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/nvmem/amlogic,meson-gxbb-efuse.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic Meson GX eFuse > + > +maintainers: > + - Neil Armstrong <neil.armstrong@linaro.org> > + > +allOf: > + - $ref: nvmem.yaml# > + > +properties: > + compatible: > + const: amlogic,meson-gxbb-efuse > + > + clocks: > + maxItems: 1 > + > + secure-monitor: > + description: phandle to the secure-monitor node This does not look like standard property, so you need the type ($ref). > + > +required: > + - compatible > + - clocks > + - secure-monitor > + Best regards, Krzysztof
On Fri, 18 Nov 2022 15:33:28 +0100, Neil Armstrong wrote: > Convert the Amlogic Meson GX eFuse bindings to dt-schema. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > .../bindings/nvmem/amlogic,meson-gxbb-efuse.yaml | 52 ++++++++++++++++++++++ > .../devicetree/bindings/nvmem/amlogic-efuse.txt | 48 -------------------- > 2 files changed, 52 insertions(+), 48 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221117-b4-amlogic-bindings-convert-v1-2-3f025599b968@linaro.org efuse: compatible:0: 'amlogic,meson-gxbb-efuse' was expected arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-meta.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s805x-p241.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-libretech-pc.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-mecool-kii-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p231.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-vero4k-plus.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905w-p281.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905w-tx3-mini.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-hwacom-amazetv.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc-v2.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-nexbox-a95x.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtb arch/arm64/boot/dts/amlogic/meson-gxm-gt1-ultimate.dtb arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dtb arch/arm64/boot/dts/amlogic/meson-gxm-mecool-kiii-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dtb arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dtb arch/arm64/boot/dts/amlogic/meson-gxm-q200.dtb arch/arm64/boot/dts/amlogic/meson-gxm-q201.dtb arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxm-s912-libretech-pc.dtb arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dtb arch/arm64/boot/dts/amlogic/meson-gxm-wetek-core2.dtb efuse: compatible: ['amlogic,meson-gx-efuse', 'amlogic,meson-gxbb-efuse'] is too long arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-meta.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s805x-p241.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-libretech-pc.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-mecool-kii-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p231.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-vero4k-plus.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905w-p281.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905w-tx3-mini.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-hwacom-amazetv.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc-v2.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-nexbox-a95x.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtb arch/arm64/boot/dts/amlogic/meson-gxm-gt1-ultimate.dtb arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dtb arch/arm64/boot/dts/amlogic/meson-gxm-mecool-kiii-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dtb arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dtb arch/arm64/boot/dts/amlogic/meson-gxm-q200.dtb arch/arm64/boot/dts/amlogic/meson-gxm-q201.dtb arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxm-s912-libretech-pc.dtb arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dtb arch/arm64/boot/dts/amlogic/meson-gxm-wetek-core2.dtb efuse: Unevaluated properties are not allowed ('compatible' was unexpected) arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-meta.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s805x-p241.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-libretech-pc.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-mecool-kii-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p231.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-vero4k-plus.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905w-p281.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905w-tx3-mini.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-hwacom-amazetv.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc-v2.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-nexbox-a95x.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtb arch/arm64/boot/dts/amlogic/meson-gxm-gt1-ultimate.dtb arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dtb arch/arm64/boot/dts/amlogic/meson-gxm-mecool-kiii-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dtb arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dtb arch/arm64/boot/dts/amlogic/meson-gxm-q200.dtb arch/arm64/boot/dts/amlogic/meson-gxm-q201.dtb arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxm-s912-libretech-pc.dtb arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dtb arch/arm64/boot/dts/amlogic/meson-gxm-wetek-core2.dtb efuse: Unevaluated properties are not allowed ('compatible', 'wifi_mac@C' were unexpected) arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dtb
diff --git a/Documentation/devicetree/bindings/nvmem/amlogic,meson-gxbb-efuse.yaml b/Documentation/devicetree/bindings/nvmem/amlogic,meson-gxbb-efuse.yaml new file mode 100644 index 000000000000..1d88f7eee840 --- /dev/null +++ b/Documentation/devicetree/bindings/nvmem/amlogic,meson-gxbb-efuse.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/nvmem/amlogic,meson-gxbb-efuse.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amlogic Meson GX eFuse + +maintainers: + - Neil Armstrong <neil.armstrong@linaro.org> + +allOf: + - $ref: nvmem.yaml# + +properties: + compatible: + const: amlogic,meson-gxbb-efuse + + clocks: + maxItems: 1 + + secure-monitor: + description: phandle to the secure-monitor node + +required: + - compatible + - clocks + - secure-monitor + +unevaluatedProperties: false + +examples: + - | + efuse: efuse { + compatible = "amlogic,meson-gxbb-efuse"; + clocks = <&clk_efuse>; + #address-cells = <1>; + #size-cells = <1>; + secure-monitor = <&sm>; + + sn: sn@14 { + reg = <0x14 0x10>; + }; + + eth_mac: mac@34 { + reg = <0x34 0x10>; + }; + + bid: bid@46 { + reg = <0x46 0x30>; + }; + }; diff --git a/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt b/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt deleted file mode 100644 index f7b3ed74db54..000000000000 --- a/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt +++ /dev/null @@ -1,48 +0,0 @@ -= Amlogic Meson GX eFuse device tree bindings = - -Required properties: -- compatible: should be "amlogic,meson-gxbb-efuse" -- clocks: phandle to the efuse peripheral clock provided by the - clock controller. -- secure-monitor: phandle to the secure-monitor node - -= Data cells = -Are child nodes of eFuse, bindings of which as described in -bindings/nvmem/nvmem.txt - -Example: - - efuse: efuse { - compatible = "amlogic,meson-gxbb-efuse"; - clocks = <&clkc CLKID_EFUSE>; - #address-cells = <1>; - #size-cells = <1>; - secure-monitor = <&sm>; - - sn: sn@14 { - reg = <0x14 0x10>; - }; - - eth_mac: eth_mac@34 { - reg = <0x34 0x10>; - }; - - bid: bid@46 { - reg = <0x46 0x30>; - }; - }; - - sm: secure-monitor { - compatible = "amlogic,meson-gxbb-sm"; - }; - -= Data consumers = -Are device nodes which consume nvmem data cells. - -For example: - - eth_mac { - ... - nvmem-cells = <ð_mac>; - nvmem-cell-names = "eth_mac"; - };
Convert the Amlogic Meson GX eFuse bindings to dt-schema. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- .../bindings/nvmem/amlogic,meson-gxbb-efuse.yaml | 52 ++++++++++++++++++++++ .../devicetree/bindings/nvmem/amlogic-efuse.txt | 48 -------------------- 2 files changed, 52 insertions(+), 48 deletions(-)