| Message ID | 20221120224101.746199-2-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: atomisp: Misc. cleanups / fixes | expand |
On Sun, Nov 20, 2022 at 11:40:42PM +0100, Hans de Goede wrote: > Standard v4l2 userspace apps do not consume the s3a statistics block > data. Until we have a userspace consumer for this (libcamera), which > might also involve changing the API for this, lower the log level > of these messages to dev_dbg() to avoid them filling up the logs. ... > - dev_warn(asd->isp->dev, "%s: drop one s3a stat which has exp_id %d!\n", > - __func__, exp_id); > + dev_dbg(asd->isp->dev, "%s: drop one s3a stat which has exp_id %d!\n", > + __func__, exp_id); Please, drop __func__ as well. Most probably this can be run on the systems with Dynamic Debug enabled, meaning that __func__ and __LINE__ can be enabled at runtime.
Hi, On 11/21/22 09:54, Andy Shevchenko wrote: > On Sun, Nov 20, 2022 at 11:40:42PM +0100, Hans de Goede wrote: >> Standard v4l2 userspace apps do not consume the s3a statistics block >> data. Until we have a userspace consumer for this (libcamera), which >> might also involve changing the API for this, lower the log level >> of these messages to dev_dbg() to avoid them filling up the logs. > > ... > >> - dev_warn(asd->isp->dev, "%s: drop one s3a stat which has exp_id %d!\n", >> - __func__, exp_id); >> + dev_dbg(asd->isp->dev, "%s: drop one s3a stat which has exp_id %d!\n", >> + __func__, exp_id); > > Please, drop __func__ as well. Most probably this can be run on the systems > with Dynamic Debug enabled, meaning that __func__ and __LINE__ can be enabled > at runtime. Fixed in my media-atomisp branch. Regards, Hans
diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c index f3f5b54bd347..21ca276831ce 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_fops.c +++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c @@ -181,8 +181,8 @@ static int atomisp_q_one_s3a_buffer(struct atomisp_sub_device *asd, } else { list_add_tail(&s3a_buf->list, &asd->s3a_stats_in_css); if (s3a_list == &asd->s3a_stats_ready) - dev_warn(asd->isp->dev, "%s: drop one s3a stat which has exp_id %d!\n", - __func__, exp_id); + dev_dbg(asd->isp->dev, "%s: drop one s3a stat which has exp_id %d!\n", + __func__, exp_id); } asd->s3a_bufs_in_css[css_pipe_id]++;
Standard v4l2 userspace apps do not consume the s3a statistics block data. Until we have a userspace consumer for this (libcamera), which might also involve changing the API for this, lower the log level of these messages to dev_dbg() to avoid them filling up the logs. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/staging/media/atomisp/pci/atomisp_fops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)