| Message ID | 20221122193415.1873179-2-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v4,1/2] media: dt-bindings: media: renesas,vsp1: Document RZ/V2L VSPD bindings | expand |
Hi all, Gentle ping. This patch is reviewed by Rob. It is blocking for accepting SoC dtsi patches[1] through renesas-soc tree 1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20221122193415.1873179-2-biju.das.jz@bp.renesas.com/ Cheers, Biju > -----Original Message----- > From: Biju Das <biju.das.jz@bp.renesas.com> > Sent: 22 November 2022 19:34 > To: Mauro Carvalho Chehab <mchehab@kernel.org>; Rob Herring > <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org> > Cc: Biju Das <biju.das.jz@bp.renesas.com>; Laurent Pinchart > <laurent.pinchart@ideasonboard.com>; linux-media@vger.kernel.org; linux- > renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; Geert Uytterhoeven > <geert+renesas@glider.be>; Fabrizio Castro <fabrizio.castro.jz@renesas.com>; > Rob Herring <robh@kernel.org> > Subject: [PATCH v4 2/2] media: dt-bindings: media: renesas,fcp: Document > RZ/{G2L,V2L} FCPVD bindings > > Document FCPVD found in RZ/G2L alike SoCs. FCPVD block is similar to FCP for > VSP found on R-Car SoC's . It has 3 clocks compared to 1 clock on fcpv. > Introduce new compatibles renesas,r9a07g044-fcpvd for RZ/G2{L,LC} and > renesas,r9a07g054-fcpvd for RZ/V2L to handle this difference. > > The 3 clocks are shared between du, vspd and fcpvd. No driver changes are > required as generic compatible string "renesas,fcpv" will be used as a > fallback. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > v3->v4: > * Added Rb tag from Rob. > v2->v3: > * Updated the compatibles by replacing items->enum as > it is just one item. > v1->v2: > * Documented RZ/{G2,V2}L FCPVD bindings > * Introduces new compatibles renesas,r9a07g0{44,54}-fcpvd > * Added clock-names property > * described clocks. > --- > .../bindings/media/renesas,fcp.yaml | 45 ++++++++++++++++--- > 1 file changed, 40 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml > b/Documentation/devicetree/bindings/media/renesas,fcp.yaml > index 43f2fed8cd33..c6abe719881b 100644 > --- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml > @@ -21,15 +21,22 @@ description: | > > properties: > compatible: > - enum: > - - renesas,fcpv # FCP for VSP > - - renesas,fcpf # FCP for FDP > + oneOf: > + - enum: > + - renesas,fcpv # FCP for VSP > + - renesas,fcpf # FCP for FDP > + - items: > + - enum: > + - renesas,r9a07g044-fcpvd # RZ/G2{L,LC} > + - renesas,r9a07g054-fcpvd # RZ/V2L > + - const: renesas,fcpv # Generic FCP for VSP fallback > > reg: > maxItems: 1 > > - clocks: > - maxItems: 1 > + clocks: true > + > + clock-names: true > > iommus: > maxItems: 1 > @@ -49,6 +56,34 @@ required: > > additionalProperties: false > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,r9a07g044-fcpvd > + - renesas,r9a07g054-fcpvd > + then: > + properties: > + clocks: > + items: > + - description: Main clock > + - description: Register access clock > + - description: Video clock > + clock-names: > + items: > + - const: aclk > + - const: pclk > + - const: vclk > + required: > + - clock-names > + else: > + properties: > + clocks: > + maxItems: 1 > + clock-names: false > + > examples: > # R8A7795 (R-Car H3) FCP for VSP-D1 > - | > -- > 2.25.1
Hi All, Gentle ping. Does this patch to be taken by media subsystem or dt? Is there any chance that it can be taken for v6.3? Cheers, Biju > Subject: RE: [PATCH v4 2/2] media: dt-bindings: media: renesas,fcp: Document > RZ/{G2L,V2L} FCPVD bindings > > Hi all, > > Gentle ping. > > This patch is reviewed by Rob. > > It is blocking for accepting SoC dtsi patches[1] through renesas-soc tree > > 1] https://patchwork.kernel.org/project/linux-renesas- > soc/patch/20221122193415.1873179-2-biju.das.jz@bp.renesas.com/ > > Cheers, > Biju > > > -----Original Message----- > > From: Biju Das <biju.das.jz@bp.renesas.com> > > Sent: 22 November 2022 19:34 > > To: Mauro Carvalho Chehab <mchehab@kernel.org>; Rob Herring > > <robh+dt@kernel.org>; Krzysztof Kozlowski > > <krzysztof.kozlowski+dt@linaro.org> > > Cc: Biju Das <biju.das.jz@bp.renesas.com>; Laurent Pinchart > > <laurent.pinchart@ideasonboard.com>; linux-media@vger.kernel.org; > > linux- renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; Geert > > Uytterhoeven <geert+renesas@glider.be>; Fabrizio Castro > > <fabrizio.castro.jz@renesas.com>; Rob Herring <robh@kernel.org> > > Subject: [PATCH v4 2/2] media: dt-bindings: media: renesas,fcp: > > Document RZ/{G2L,V2L} FCPVD bindings > > > > Document FCPVD found in RZ/G2L alike SoCs. FCPVD block is similar to > > FCP for VSP found on R-Car SoC's . It has 3 clocks compared to 1 clock on > fcpv. > > Introduce new compatibles renesas,r9a07g044-fcpvd for RZ/G2{L,LC} and > > renesas,r9a07g054-fcpvd for RZ/V2L to handle this difference. > > > > The 3 clocks are shared between du, vspd and fcpvd. No driver changes > > are required as generic compatible string "renesas,fcpv" will be used > > as a fallback. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > > v3->v4: > > * Added Rb tag from Rob. > > v2->v3: > > * Updated the compatibles by replacing items->enum as > > it is just one item. > > v1->v2: > > * Documented RZ/{G2,V2}L FCPVD bindings > > * Introduces new compatibles renesas,r9a07g0{44,54}-fcpvd > > * Added clock-names property > > * described clocks. > > --- > > .../bindings/media/renesas,fcp.yaml | 45 ++++++++++++++++--- > > 1 file changed, 40 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml > > b/Documentation/devicetree/bindings/media/renesas,fcp.yaml > > index 43f2fed8cd33..c6abe719881b 100644 > > --- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml > > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml > > @@ -21,15 +21,22 @@ description: | > > > > properties: > > compatible: > > - enum: > > - - renesas,fcpv # FCP for VSP > > - - renesas,fcpf # FCP for FDP > > + oneOf: > > + - enum: > > + - renesas,fcpv # FCP for VSP > > + - renesas,fcpf # FCP for FDP > > + - items: > > + - enum: > > + - renesas,r9a07g044-fcpvd # RZ/G2{L,LC} > > + - renesas,r9a07g054-fcpvd # RZ/V2L > > + - const: renesas,fcpv # Generic FCP for VSP fallback > > > > reg: > > maxItems: 1 > > > > - clocks: > > - maxItems: 1 > > + clocks: true > > + > > + clock-names: true > > > > iommus: > > maxItems: 1 > > @@ -49,6 +56,34 @@ required: > > > > additionalProperties: false > > > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - renesas,r9a07g044-fcpvd > > + - renesas,r9a07g054-fcpvd > > + then: > > + properties: > > + clocks: > > + items: > > + - description: Main clock > > + - description: Register access clock > > + - description: Video clock > > + clock-names: > > + items: > > + - const: aclk > > + - const: pclk > > + - const: vclk > > + required: > > + - clock-names > > + else: > > + properties: > > + clocks: > > + maxItems: 1 > > + clock-names: false > > + > > examples: > > # R8A7795 (R-Car H3) FCP for VSP-D1 > > - | > > -- > > 2.25.1
Hi All, Gentle ping. Looks like this patch is missed since November 2022( almost 4 months). Cheers, Biju > Subject: RE: [PATCH v4 2/2] media: dt-bindings: media: renesas,fcp: Document > RZ/{G2L,V2L} FCPVD bindings > > Hi All, > > Gentle ping. Does this patch to be taken by media subsystem or dt? > > Is there any chance that it can be taken for v6.3? > > Cheers, > Biju > > > > Subject: RE: [PATCH v4 2/2] media: dt-bindings: media: renesas,fcp: > > Document RZ/{G2L,V2L} FCPVD bindings > > > > Hi all, > > > > Gentle ping. > > > > This patch is reviewed by Rob. > > > > It is blocking for accepting SoC dtsi patches[1] through renesas-soc > > tree > > > > 1] https://patchwork.kernel.org/project/linux-renesas- > > soc/patch/20221122193415.1873179-2-biju.das.jz@bp.renesas.com/ > > > > Cheers, > > Biju > > > > > -----Original Message----- > > > From: Biju Das <biju.das.jz@bp.renesas.com> > > > Sent: 22 November 2022 19:34 > > > To: Mauro Carvalho Chehab <mchehab@kernel.org>; Rob Herring > > > <robh+dt@kernel.org>; Krzysztof Kozlowski > > > <krzysztof.kozlowski+dt@linaro.org> > > > Cc: Biju Das <biju.das.jz@bp.renesas.com>; Laurent Pinchart > > > <laurent.pinchart@ideasonboard.com>; linux-media@vger.kernel.org; > > > linux- renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; > > > Geert Uytterhoeven <geert+renesas@glider.be>; Fabrizio Castro > > > <fabrizio.castro.jz@renesas.com>; Rob Herring <robh@kernel.org> > > > Subject: [PATCH v4 2/2] media: dt-bindings: media: renesas,fcp: > > > Document RZ/{G2L,V2L} FCPVD bindings > > > > > > Document FCPVD found in RZ/G2L alike SoCs. FCPVD block is similar to > > > FCP for VSP found on R-Car SoC's . It has 3 clocks compared to 1 > > > clock on > > fcpv. > > > Introduce new compatibles renesas,r9a07g044-fcpvd for RZ/G2{L,LC} > > > and renesas,r9a07g054-fcpvd for RZ/V2L to handle this difference. > > > > > > The 3 clocks are shared between du, vspd and fcpvd. No driver > > > changes are required as generic compatible string "renesas,fcpv" > > > will be used as a fallback. > > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > --- > > > v3->v4: > > > * Added Rb tag from Rob. > > > v2->v3: > > > * Updated the compatibles by replacing items->enum as > > > it is just one item. > > > v1->v2: > > > * Documented RZ/{G2,V2}L FCPVD bindings > > > * Introduces new compatibles renesas,r9a07g0{44,54}-fcpvd > > > * Added clock-names property > > > * described clocks. > > > --- > > > .../bindings/media/renesas,fcp.yaml | 45 ++++++++++++++++--- > > > 1 file changed, 40 insertions(+), 5 deletions(-) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/media/renesas,fcp.yaml > > > b/Documentation/devicetree/bindings/media/renesas,fcp.yaml > > > index 43f2fed8cd33..c6abe719881b 100644 > > > --- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml > > > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml > > > @@ -21,15 +21,22 @@ description: | > > > > > > properties: > > > compatible: > > > - enum: > > > - - renesas,fcpv # FCP for VSP > > > - - renesas,fcpf # FCP for FDP > > > + oneOf: > > > + - enum: > > > + - renesas,fcpv # FCP for VSP > > > + - renesas,fcpf # FCP for FDP > > > + - items: > > > + - enum: > > > + - renesas,r9a07g044-fcpvd # RZ/G2{L,LC} > > > + - renesas,r9a07g054-fcpvd # RZ/V2L > > > + - const: renesas,fcpv # Generic FCP for VSP fallback > > > > > > reg: > > > maxItems: 1 > > > > > > - clocks: > > > - maxItems: 1 > > > + clocks: true > > > + > > > + clock-names: true > > > > > > iommus: > > > maxItems: 1 > > > @@ -49,6 +56,34 @@ required: > > > > > > additionalProperties: false > > > > > > +allOf: > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + enum: > > > + - renesas,r9a07g044-fcpvd > > > + - renesas,r9a07g054-fcpvd > > > + then: > > > + properties: > > > + clocks: > > > + items: > > > + - description: Main clock > > > + - description: Register access clock > > > + - description: Video clock > > > + clock-names: > > > + items: > > > + - const: aclk > > > + - const: pclk > > > + - const: vclk > > > + required: > > > + - clock-names > > > + else: > > > + properties: > > > + clocks: > > > + maxItems: 1 > > > + clock-names: false > > > + > > > examples: > > > # R8A7795 (R-Car H3) FCP for VSP-D1 > > > - | > > > -- > > > 2.25.1
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml index 43f2fed8cd33..c6abe719881b 100644 --- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml @@ -21,15 +21,22 @@ description: | properties: compatible: - enum: - - renesas,fcpv # FCP for VSP - - renesas,fcpf # FCP for FDP + oneOf: + - enum: + - renesas,fcpv # FCP for VSP + - renesas,fcpf # FCP for FDP + - items: + - enum: + - renesas,r9a07g044-fcpvd # RZ/G2{L,LC} + - renesas,r9a07g054-fcpvd # RZ/V2L + - const: renesas,fcpv # Generic FCP for VSP fallback reg: maxItems: 1 - clocks: - maxItems: 1 + clocks: true + + clock-names: true iommus: maxItems: 1 @@ -49,6 +56,34 @@ required: additionalProperties: false +allOf: + - if: + properties: + compatible: + contains: + enum: + - renesas,r9a07g044-fcpvd + - renesas,r9a07g054-fcpvd + then: + properties: + clocks: + items: + - description: Main clock + - description: Register access clock + - description: Video clock + clock-names: + items: + - const: aclk + - const: pclk + - const: vclk + required: + - clock-names + else: + properties: + clocks: + maxItems: 1 + clock-names: false + examples: # R8A7795 (R-Car H3) FCP for VSP-D1 - |
Document FCPVD found in RZ/G2L alike SoCs. FCPVD block is similar to FCP for VSP found on R-Car SoC's . It has 3 clocks compared to 1 clock on fcpv. Introduce new compatibles renesas,r9a07g044-fcpvd for RZ/G2{L,LC} and renesas,r9a07g054-fcpvd for RZ/V2L to handle this difference. The 3 clocks are shared between du, vspd and fcpvd. No driver changes are required as generic compatible string "renesas,fcpv" will be used as a fallback. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Rob Herring <robh@kernel.org> --- v3->v4: * Added Rb tag from Rob. v2->v3: * Updated the compatibles by replacing items->enum as it is just one item. v1->v2: * Documented RZ/{G2,V2}L FCPVD bindings * Introduces new compatibles renesas,r9a07g0{44,54}-fcpvd * Added clock-names property * described clocks. --- .../bindings/media/renesas,fcp.yaml | 45 ++++++++++++++++--- 1 file changed, 40 insertions(+), 5 deletions(-)