diff mbox series

[v3] media: ov5640: set correct default link frequency

Message ID 20221125092024.2866111-1-guoniu.zhou@nxp.com (mailing list archive)
State New, archived
Headers show
Series [v3] media: ov5640: set correct default link frequency | expand

Commit Message

G.N. Zhou Nov. 25, 2022, 9:20 a.m. UTC
current_link_freq field in ov5640_dev structure is link frequency,
not link frequency array index, so correct it.

Fixes: 3c28588f35d3 ("media: ov5640: Update pixel_rate and link_freq")
Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com>
Acked-by: Jacopo Mondi <jacopo@jmondi.org>
---
v3:
  - Remove empty line after Fixes: 3c28588f35d3 ("media: ov5640: Update pixel_rate and link_freq")
  - Add "Acked-by: Jacopo Mondi <jacopo@jmondi.org>"

v2:
 - Correct typo issue(s/structrue/structure)
---
 drivers/media/i2c/ov5640.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Laurent Pinchart Nov. 28, 2022, 2:29 p.m. UTC | #1
Hi Guoniu zhou,

Thank you for the patch.

On Fri, Nov 25, 2022 at 05:20:24PM +0800, Guoniu.zhou wrote:
> current_link_freq field in ov5640_dev structure is link frequency,
> not link frequency array index, so correct it.
> 
> Fixes: 3c28588f35d3 ("media: ov5640: Update pixel_rate and link_freq")
> Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com>
> Acked-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> v3:
>   - Remove empty line after Fixes: 3c28588f35d3 ("media: ov5640: Update pixel_rate and link_freq")
>   - Add "Acked-by: Jacopo Mondi <jacopo@jmondi.org>"
> 
> v2:
>  - Correct typo issue(s/structrue/structure)
> ---
>  drivers/media/i2c/ov5640.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> index 2d740397a5d4..3f6d715efa82 100644
> --- a/drivers/media/i2c/ov5640.c
> +++ b/drivers/media/i2c/ov5640.c
> @@ -3817,7 +3817,8 @@ static int ov5640_probe(struct i2c_client *client)
>  	sensor->current_mode =
>  		&ov5640_mode_data[OV5640_MODE_VGA_640_480];
>  	sensor->last_mode = sensor->current_mode;
> -	sensor->current_link_freq = OV5640_DEFAULT_LINK_FREQ;
> +	sensor->current_link_freq =
> +		ov5640_csi2_link_freqs[OV5640_DEFAULT_LINK_FREQ];
>  
>  	sensor->ae_target = 52;
>
diff mbox series

Patch

diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index 2d740397a5d4..3f6d715efa82 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -3817,7 +3817,8 @@  static int ov5640_probe(struct i2c_client *client)
 	sensor->current_mode =
 		&ov5640_mode_data[OV5640_MODE_VGA_640_480];
 	sensor->last_mode = sensor->current_mode;
-	sensor->current_link_freq = OV5640_DEFAULT_LINK_FREQ;
+	sensor->current_link_freq =
+		ov5640_csi2_link_freqs[OV5640_DEFAULT_LINK_FREQ];
 
 	sensor->ae_target = 52;