[v4,1/2] dt-bindings: media: i2c: Add IMX519 CMOS sensor binding

Commit Message

Lee Jackson Dec. 5, 2022, 2:38 a.m. UTC

Add YAML device tree binding for IMX519 CMOS image sensor, and
the relevant MAINTAINERS entries.

Signed-off-by: lee.jackson <[e-mail] >
---
 .../bindings/media/i2c/sony,imx519.yaml       | 107 ++++++++++++++++++
 MAINTAINERS                                   |   8 ++
 2 files changed, 115 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml

Comments

Krzysztof Kozlowski Dec. 5, 2022, 1:20 p.m. UTC | #1

On 05/12/2022 13:57, Kieran Bingham wrote:
> Hi Lee,
> 
> To try to avoid these circles, I've gone through and detailed precisely
> how the name and e-mail address should be formed to meet expectations.
> 
> Please also handle the other comments from Krzysztof for a v5.
> 
> Quoting lee.jackson (2022-12-05 02:38:00)
>> Add YAML device tree binding for IMX519 CMOS image sensor, and
>> the relevant MAINTAINERS entries.
>>
>> Signed-off-by: lee.jackson <[e-mail] >
> 
> Please ensure you configure your git client as follows:
> 
>   git config --global user.name "Lee Jackson"
>   git config --global user.email "[e-mail]"

... and then: git commit --amend --reset-author --signoff

Best regards,
Krzysztof

Lee Jackson Dec. 9, 2022, 1:09 a.m. UTC | #2

On Mon, 5 Dec 2022 14:20:07 +0100
Krzysztof Kozlowski <[e-mail]> wrote:

> On 05/12/2022 13:57, Kieran Bingham wrote:
> > Hi Lee,
> > 
> > To try to avoid these circles, I've gone through and detailed
> > precisely how the name and e-mail address should be formed to meet
> > expectations.
> > 
> > Please also handle the other comments from Krzysztof for a v5.
> > 
> > Quoting lee.jackson (2022-12-05 02:38:00)  
> >> Add YAML device tree binding for IMX519 CMOS image sensor, and
> >> the relevant MAINTAINERS entries.
> >>
> >> Signed-off-by: lee.jackson <[e-mail] >  
> > 
> > Please ensure you configure your git client as follows:
> > 
> >   git config --global user.name "Lee Jackson"
> >   git config --global user.email "[e-mail]"  
> 
> ... and then: git commit --amend --reset-author --signoff
> 
> Best regards,
> Krzysztof
> 

Hi Krzysztof,
Thank you very much for your patience. I have resubmitted V5 following your revision guide suggestion.
Sorry again for wasting your time and thank you again for your detail sugguestion.
Best regards,
Lee Jackson

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml
new file mode 100644
index 000000000000..d7ca16cfbacc
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml
@@ -0,0 +1,107 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/sony,imx519.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor
+
+maintainers:
+  - lee.jackson <[e-mail]>
+
+description: |-
+  The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital image sensor
+  with an active array size of 4656H x 3496V. It is programmable through
+  I2C interface. The I2C address is fixed to 0x1A as per sensor data sheet.
+  Image data is sent through MIPI CSI-2, which is configured as either 2 or
+  4 data lanes.
+
+properties:
+  compatible:
+    const: sony,imx519
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  vdig-supply:
+    description:
+      Digital I/O voltage supply, 1.05 volts
+
+  vana-supply:
+    description:
+      Analog voltage supply, 2.8 volts
+
+  vddl-supply:
+    description:
+      Digital core voltage supply, 1.8 volts
+
+  reset-gpios:
+    description: |-
+      Reference to the GPIO connected to the xclr pin, if any.
+      Must be released (set high) after all supplies and INCK are applied.
+
+  port:
+    $ref: /schemas/graph.yaml#/$defs/port-base
+    additionalProperties: false
+
+    properties:
+      endpoint:
+        $ref: /schemas/media/video-interfaces.yaml#
+        unevaluatedProperties: false
+
+        properties:
+          data-lanes:
+            anyOf:
+              - items:
+                  - const: 1
+                  - const: 2
+              - items:
+                  - const: 1
+                  - const: 2
+                  - const: 3
+                  - const: 4
+
+        required:
+          - data-lanes
+          - link-frequencies
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - vana-supply
+  - vdig-supply
+  - vddl-supply
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        imx519: sensor@1a {
+            compatible = "sony,imx519";
+            reg = <0x1a>;
+            clocks = <&imx519_clk>;
+            vana-supply = <&imx519_vana>;   /* 2.8v */
+            vdig-supply = <&imx519_vdig>;   /* 1.05v */
+            vddl-supply = <&imx519_vddl>;   /* 1.8v */
+
+            port {
+                imx519_0: endpoint {
+                    remote-endpoint = <&csi1_ep>;
+                    data-lanes = <1 2>;
+                    clock-noncontinuous;
+                    link-frequencies = /bits/ 64 <493500000>;
+                };
+            };
+        };
+    };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 046ff06ff97f..1fe906632209 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19232,6 +19232,14 @@  T:	git git://linuxtv.org/media_tree.git
 F:	Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
 F:	drivers/media/i2c/imx412.c
 
+SONY IMX519 SENSOR DRIVER
+M:	Arducam Kernel Maintenance <[e-mail]>
+M:	lee.jackson <[e-mail]>
+L:	[e-mail]
+S:	Maintained
+T:	git git://linuxtv.org/media_tree.git
+F:	Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml
+
 SONY MEMORYSTICK SUBSYSTEM
 M:	Maxim Levitsky <[e-mail]>
 M:	Alex Dubov <[e-mail]>