| Message ID | 20230114171802.13878-17-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: i2c: imx290: Miscellaneous improvements | expand |
Hi Laurent, thanks for the update. Am Samstag, 14. Januar 2023, 18:18:02 CET schrieb Laurent Pinchart: > Check the error status returned by imx290_set_data_lanes() in its > caller and propagate it. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > Changes since v1: > > - New patch > --- > drivers/media/i2c/imx290.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c > index a8167119534b..62d8d75aec3e 100644 > --- a/drivers/media/i2c/imx290.c > +++ b/drivers/media/i2c/imx290.c > @@ -761,7 +761,11 @@ static int imx290_start_streaming(struct imx290 > *imx290, } > > /* Set data lane count */ > - imx290_set_data_lanes(imx290); > + ret = imx290_set_data_lanes(imx290); > + if (ret < 0) { > + dev_err(imx290->dev, "Could not set data lanes\n"); > + return ret; > + } > > /* Apply the register values related to current frame format */ > format = v4l2_subdev_get_pad_format(&imx290->sd, state, 0);
diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c index a8167119534b..62d8d75aec3e 100644 --- a/drivers/media/i2c/imx290.c +++ b/drivers/media/i2c/imx290.c @@ -761,7 +761,11 @@ static int imx290_start_streaming(struct imx290 *imx290, } /* Set data lane count */ - imx290_set_data_lanes(imx290); + ret = imx290_set_data_lanes(imx290); + if (ret < 0) { + dev_err(imx290->dev, "Could not set data lanes\n"); + return ret; + } /* Apply the register values related to current frame format */ format = v4l2_subdev_get_pad_format(&imx290->sd, state, 0);
Check the error status returned by imx290_set_data_lanes() in its caller and propagate it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- Changes since v1: - New patch --- drivers/media/i2c/imx290.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)