| Message ID | 20230123125205.622152-46-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: atomisp: Big power-management changes + lots of fixes | expand |
On Mon, Jan 23, 2023 at 01:51:53PM +0100, Hans de Goede wrote: > Remove unused includes and sort the remaining ones alphabetically. Reviewed-by: Andy Shevchenko <andy@kernel.org> See below. > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > .../media/atomisp/i2c/atomisp-ov2680.c | 19 +++---------------- > 1 file changed, 3 insertions(+), 16 deletions(-) > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c > index 994b6fe40069..1dc821ca4e68 100644 > --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c > +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c > @@ -15,27 +15,14 @@ > * > */ > > -#include <asm/unaligned.h> > - > -#include <linux/module.h> > -#include <linux/types.h> > -#include <linux/kernel.h> > -#include <linux/mm.h> > -#include <linux/string.h> > -#include <linux/errno.h> > -#include <linux/init.h> > -#include <linux/kmod.h> > +#include <linux/acpi.h> > #include <linux/device.h> > -#include <linux/delay.h> > -#include <linux/slab.h> > #include <linux/i2c.h> > -#include <linux/moduleparam.h> > +#include <linux/module.h> > +#include <linux/types.h> + Blank line? > #include <media/ovxxxx_16bit_addr_reg_helpers.h> > #include <media/v4l2-device.h> > -#include <linux/io.h> > -#include <linux/acpi.h> + Blank line? > #include "../include/linux/atomisp_gmin_platform.h" > - I would leave it to make separate groups of headers. > #include "ov2680.h" > > static enum atomisp_bayer_order ov2680_bayer_order_mapping[] = { > -- > 2.39.0 >
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c index 994b6fe40069..1dc821ca4e68 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c @@ -15,27 +15,14 @@ * */ -#include <asm/unaligned.h> - -#include <linux/module.h> -#include <linux/types.h> -#include <linux/kernel.h> -#include <linux/mm.h> -#include <linux/string.h> -#include <linux/errno.h> -#include <linux/init.h> -#include <linux/kmod.h> +#include <linux/acpi.h> #include <linux/device.h> -#include <linux/delay.h> -#include <linux/slab.h> #include <linux/i2c.h> -#include <linux/moduleparam.h> +#include <linux/module.h> +#include <linux/types.h> #include <media/ovxxxx_16bit_addr_reg_helpers.h> #include <media/v4l2-device.h> -#include <linux/io.h> -#include <linux/acpi.h> #include "../include/linux/atomisp_gmin_platform.h" - #include "ov2680.h" static enum atomisp_bayer_order ov2680_bayer_order_mapping[] = {
Remove unused includes and sort the remaining ones alphabetically. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- .../media/atomisp/i2c/atomisp-ov2680.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-)