| Message ID | 20230208113348.16880-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,1/1] media: i2c: imx290: Use device_property_read_u32() directly | expand |
Hi Andy, Thank you for the patch. On Wed, Feb 08, 2023 at 01:33:48PM +0200, Andy Shevchenko wrote: > No need to call fwnode_property_read_u32(dev_fwnode()), when > we have already existing helper. So use it. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/media/i2c/imx290.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c > index 330098a0772d..e7aa2ecdcc88 100644 > --- a/drivers/media/i2c/imx290.c > +++ b/drivers/media/i2c/imx290.c > @@ -1137,8 +1137,7 @@ static int imx290_init_clk(struct imx290 *imx290) > u32 xclk_freq; > int ret; > > - ret = fwnode_property_read_u32(dev_fwnode(imx290->dev), > - "clock-frequency", &xclk_freq); > + ret = device_property_read_u32(imx290->dev, "clock-frequency", &xclk_freq); I'd break the line here. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > if (ret) { > dev_err(imx290->dev, "Could not get xclk frequency\n"); > return ret;
diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c index 330098a0772d..e7aa2ecdcc88 100644 --- a/drivers/media/i2c/imx290.c +++ b/drivers/media/i2c/imx290.c @@ -1137,8 +1137,7 @@ static int imx290_init_clk(struct imx290 *imx290) u32 xclk_freq; int ret; - ret = fwnode_property_read_u32(dev_fwnode(imx290->dev), - "clock-frequency", &xclk_freq); + ret = device_property_read_u32(imx290->dev, "clock-frequency", &xclk_freq); if (ret) { dev_err(imx290->dev, "Could not get xclk frequency\n"); return ret;
No need to call fwnode_property_read_u32(dev_fwnode()), when we have already existing helper. So use it. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/media/i2c/imx290.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)