diff mbox series

media: dw100: use devm_platform_get_and_ioremap_resource()

Message ID 202302081635445002151@zte.com.cn (mailing list archive)
State New, archived
Headers show
Series media: dw100: use devm_platform_get_and_ioremap_resource() | expand

Commit Message

ye.xingchen@zte.com.cn Feb. 8, 2023, 8:35 a.m. UTC 
From: Ye Xingchen <ye.xingchen@zte.com.cn>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
 drivers/media/platform/nxp/dw100/dw100.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Xavier Roumegue (OSS) Feb. 8, 2023, 10:12 a.m. UTC | #1 
Hi Ye Xingchen,

Thanks for your patch.

On 2/8/23 09:35, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>

Reviewed-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>

Regards,
  Xavier

> ---
>   drivers/media/platform/nxp/dw100/dw100.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/nxp/dw100/dw100.c b/drivers/media/platform/nxp/dw100/dw100.c
> index 189d60cd5ed1..0771a88122c0 100644
> --- a/drivers/media/platform/nxp/dw100/dw100.c
> +++ b/drivers/media/platform/nxp/dw100/dw100.c
> @@ -1532,7 +1532,6 @@ static int dw100_probe(struct platform_device *pdev)
>   {
>   	struct dw100_device *dw_dev;
>   	struct video_device *vfd;
> -	struct resource *res;
>   	int ret, irq;
> 
>   	dw_dev = devm_kzalloc(&pdev->dev, sizeof(*dw_dev), GFP_KERNEL);
> @@ -1547,8 +1546,7 @@ static int dw100_probe(struct platform_device *pdev)
>   	}
>   	dw_dev->num_clks = ret;
> 
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	dw_dev->mmio = devm_ioremap_resource(&pdev->dev, res);
> +	dw_dev->mmio = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
>   	if (IS_ERR(dw_dev->mmio))
>   		return PTR_ERR(dw_dev->mmio);
>
diff mbox series

Patch

diff --git a/drivers/media/platform/nxp/dw100/dw100.c b/drivers/media/platform/nxp/dw100/dw100.c
index 189d60cd5ed1..0771a88122c0 100644
--- a/drivers/media/platform/nxp/dw100/dw100.c
+++ b/drivers/media/platform/nxp/dw100/dw100.c
@@ -1532,7 +1532,6 @@  static int dw100_probe(struct platform_device *pdev)
 {
 	struct dw100_device *dw_dev;
 	struct video_device *vfd;
-	struct resource *res;
 	int ret, irq;

 	dw_dev = devm_kzalloc(&pdev->dev, sizeof(*dw_dev), GFP_KERNEL);
@@ -1547,8 +1546,7 @@  static int dw100_probe(struct platform_device *pdev)
 	}
 	dw_dev->num_clks = ret;

-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	dw_dev->mmio = devm_ioremap_resource(&pdev->dev, res);
+	dw_dev->mmio = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
 	if (IS_ERR(dw_dev->mmio))
 		return PTR_ERR(dw_dev->mmio);