| Message ID | 20230218031238.5747-1-vishistriker@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | first patch test | expand |
Hey Vishal, actually sending noise to the mailing list is not very nice. And you also just did the same mistake as someone else a few weeks ago. Please see this mail: https://lore.kernel.org/linux-media/49d1dece-cb90-23f3-977e-98905b1a0abc@collabora.com/ If you don't know what to do for your first patch, then either ask in the mailing list or have a look into the TODO files in drivers/staging/media or ask on the IRC channel: https://linuxtv.org/irc/ Greetings, Sebastian On 18.02.2023 08:42, Vishal Parmar wrote: >Signed-off-by: Vishal Parmar <vishistriker@gmail.com> >--- > drivers/media/usb/uvc/uvc_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c >index e4bcb5011360..c79dcee2213f 100644 >--- a/drivers/media/usb/uvc/uvc_driver.c >+++ b/drivers/media/usb/uvc/uvc_driver.c >@@ -2082,7 +2082,7 @@ static int uvc_probe(struct usb_interface *intf, > (const struct uvc_device_info *)id->driver_info; > int function; > int ret; >- >+ pr_info("I changed uvcvideo driver in the Linux Kernel\n"); > /* Allocate memory for the device and initialize it. */ > dev = kzalloc(sizeof(*dev), GFP_KERNEL); > if (dev == NULL) >-- >2.34.1 >
On Sat, Feb 18, 2023 at 08:42:37AM +0530, Vishal Parmar wrote: > Signed-off-by: Vishal Parmar <vishistriker@gmail.com> > --- > drivers/media/usb/uvc/uvc_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > index e4bcb5011360..c79dcee2213f 100644 > --- a/drivers/media/usb/uvc/uvc_driver.c > +++ b/drivers/media/usb/uvc/uvc_driver.c > @@ -2082,7 +2082,7 @@ static int uvc_probe(struct usb_interface *intf, > (const struct uvc_device_info *)id->driver_info; > int function; > int ret; > - > + pr_info("I changed uvcvideo driver in the Linux Kernel\n"); > /* Allocate memory for the device and initialize it. */ > dev = kzalloc(sizeof(*dev), GFP_KERNEL); > if (dev == NULL) Hi and welcome to LKML! As others has pointed, it seems like you had sent a patch which only added noises to the ML. Also, I see that you send the similar change as one in "Modifying a driver under the VM" section of kernelnewbies.org [1]. If you'd like to submit patches, you can do so by contributing to drivers/staging/ drivers first or documentation files at Documentation/. It is not recommended to go outside of there until you've gained experience and have several of your patches accepted and applied by respective maintainers. In any case, please read Documentation/process/submitting-patches.rst. Thanks. [1]: https://kernelnewbies.org/FirstKernelPatch
On Sat, Feb 18, 2023 at 04:41:27PM +0700, Bagas Sanjaya wrote: > On Sat, Feb 18, 2023 at 08:42:37AM +0530, Vishal Parmar wrote: > > Signed-off-by: Vishal Parmar <vishistriker@gmail.com> > > --- > > drivers/media/usb/uvc/uvc_driver.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > > index e4bcb5011360..c79dcee2213f 100644 > > --- a/drivers/media/usb/uvc/uvc_driver.c > > +++ b/drivers/media/usb/uvc/uvc_driver.c > > @@ -2082,7 +2082,7 @@ static int uvc_probe(struct usb_interface *intf, > > (const struct uvc_device_info *)id->driver_info; > > int function; > > int ret; > > - > > + pr_info("I changed uvcvideo driver in the Linux Kernel\n"); > > /* Allocate memory for the device and initialize it. */ > > dev = kzalloc(sizeof(*dev), GFP_KERNEL); > > if (dev == NULL) > > Hi and welcome to LKML! > > As others has pointed, it seems like you had sent a patch which only > added noises to the ML. Also, I see that you send the similar change as > one in "Modifying a driver under the VM" section of kernelnewbies.org > [1]. Vishal, could you please point us to the exact location of the instructions you've interpreted as telling you to send this patch out ? I'd like to get that fixed to avoid similar noise in the future. > If you'd like to submit patches, you can do so by contributing to > drivers/staging/ drivers first or documentation files at Documentation/. > It is not recommended to go outside of there until you've gained > experience and have several of your patches accepted and applied by > respective maintainers. > > In any case, please read Documentation/process/submitting-patches.rst. > > Thanks. > > [1]: https://kernelnewbies.org/FirstKernelPatch
diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c index e4bcb5011360..c79dcee2213f 100644 --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -2082,7 +2082,7 @@ static int uvc_probe(struct usb_interface *intf, (const struct uvc_device_info *)id->driver_info; int function; int ret; - + pr_info("I changed uvcvideo driver in the Linux Kernel\n"); /* Allocate memory for the device and initialize it. */ dev = kzalloc(sizeof(*dev), GFP_KERNEL); if (dev == NULL)
Signed-off-by: Vishal Parmar <vishistriker@gmail.com> --- drivers/media/usb/uvc/uvc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)