diff mbox series

[v2] media: ipu3-cio2: support more camera sensors in cio2-bridge

Message ID 20230303181504.1813469-1-bingbu.cao@intel.com (mailing list archive)
State New, archived
Headers show
Series [v2] media: ipu3-cio2: support more camera sensors in cio2-bridge | expand

Commit Message

Bingbu Cao March 3, 2023, 6:15 p.m. UTC
From: Bingbu Cao <bingbu.cao@intel.com>

Add more camera sensors into the supported camera sensors list
to make cio2-bridge to support more camera sensors.

Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
---
Changes from v1:
 - remove some sensors without available drivers
 - add .link_frequencies for each sensor

---
 drivers/media/pci/intel/ipu3/cio2-bridge.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Daniel Scally March 6, 2023, 9:34 a.m. UTC | #1
Good morning Bingbu

On 03/03/2023 18:15, bingbu.cao@intel.com wrote:
> From: Bingbu Cao <bingbu.cao@intel.com>
>
> Add more camera sensors into the supported camera sensors list
> to make cio2-bridge to support more camera sensors.
>
> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>

Thanks; this looks ok to me now:


Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

> ---
> Changes from v1:
>   - remove some sensors without available drivers
>   - add .link_frequencies for each sensor
>
> ---
>   drivers/media/pci/intel/ipu3/cio2-bridge.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.c b/drivers/media/pci/intel/ipu3/cio2-bridge.c
> index dfefe0d8aa95..d59bec8a94e2 100644
> --- a/drivers/media/pci/intel/ipu3/cio2-bridge.c
> +++ b/drivers/media/pci/intel/ipu3/cio2-bridge.c
> @@ -29,6 +29,14 @@ static const struct cio2_sensor_config cio2_supported_sensors[] = {
>   	CIO2_SENSOR_CONFIG("INT347E", 1, 319200000),
>   	/* Omnivision OV2680 */
>   	CIO2_SENSOR_CONFIG("OVTI2680", 0),
> +	/* Omnivision ov8856 */
> +	CIO2_SENSOR_CONFIG("OVTI8856", 3, 180000000, 360000000, 720000000),
> +	/* Omnivision ov2740 */
> +	CIO2_SENSOR_CONFIG("INT3474", 1, 360000000),
> +	/* Hynix hi556 */
> +	CIO2_SENSOR_CONFIG("INT3537", 1, 437000000),
> +	/* Omnivision ov13b10 */
> +	CIO2_SENSOR_CONFIG("OVTIDB10", 1, 560000000),
>   };
>   
>   static const struct cio2_property_names prop_names = {
Bingbu Cao March 31, 2023, 1 p.m. UTC | #2
On 3/6/23 5:34 PM, Dan Scally wrote:
> Good morning Bingbu
> 
> On 03/03/2023 18:15, bingbu.cao@intel.com wrote:
>> From: Bingbu Cao <bingbu.cao@intel.com>
>>
>> Add more camera sensors into the supported camera sensors list
>> to make cio2-bridge to support more camera sensors.
>>
>> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> 
> Thanks; this looks ok to me now:
> 
> 
> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
> 
Sakari, 

Will you pick this change?

>> ---
>> Changes from v1:
>>   - remove some sensors without available drivers
>>   - add .link_frequencies for each sensor
>>
>> ---
>>   drivers/media/pci/intel/ipu3/cio2-bridge.c | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.c b/drivers/media/pci/intel/ipu3/cio2-bridge.c
>> index dfefe0d8aa95..d59bec8a94e2 100644
>> --- a/drivers/media/pci/intel/ipu3/cio2-bridge.c
>> +++ b/drivers/media/pci/intel/ipu3/cio2-bridge.c
>> @@ -29,6 +29,14 @@ static const struct cio2_sensor_config cio2_supported_sensors[] = {
>>       CIO2_SENSOR_CONFIG("INT347E", 1, 319200000),
>>       /* Omnivision OV2680 */
>>       CIO2_SENSOR_CONFIG("OVTI2680", 0),
>> +    /* Omnivision ov8856 */
>> +    CIO2_SENSOR_CONFIG("OVTI8856", 3, 180000000, 360000000, 720000000),
>> +    /* Omnivision ov2740 */
>> +    CIO2_SENSOR_CONFIG("INT3474", 1, 360000000),
>> +    /* Hynix hi556 */
>> +    CIO2_SENSOR_CONFIG("INT3537", 1, 437000000),
>> +    /* Omnivision ov13b10 */
>> +    CIO2_SENSOR_CONFIG("OVTIDB10", 1, 560000000),
>>   };
>>     static const struct cio2_property_names prop_names = {
Sakari Ailus March 31, 2023, 1:03 p.m. UTC | #3
Hi Bingbu,

On Fri, Mar 31, 2023 at 09:00:09PM +0800, Bingbu Cao wrote:
> 
> On 3/6/23 5:34 PM, Dan Scally wrote:
> > Good morning Bingbu
> > 
> > On 03/03/2023 18:15, bingbu.cao@intel.com wrote:
> >> From: Bingbu Cao <bingbu.cao@intel.com>
> >>
> >> Add more camera sensors into the supported camera sensors list
> >> to make cio2-bridge to support more camera sensors.
> >>
> >> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> > 
> > Thanks; this looks ok to me now:
> > 
> > 
> > Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
> > 
> Sakari, 
> 
> Will you pick this change?

Thanks for the ping. I must have mistakenly mark this as "under review" in
patchwork earlier. It's in my tree now.
diff mbox series

Patch

diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.c b/drivers/media/pci/intel/ipu3/cio2-bridge.c
index dfefe0d8aa95..d59bec8a94e2 100644
--- a/drivers/media/pci/intel/ipu3/cio2-bridge.c
+++ b/drivers/media/pci/intel/ipu3/cio2-bridge.c
@@ -29,6 +29,14 @@  static const struct cio2_sensor_config cio2_supported_sensors[] = {
 	CIO2_SENSOR_CONFIG("INT347E", 1, 319200000),
 	/* Omnivision OV2680 */
 	CIO2_SENSOR_CONFIG("OVTI2680", 0),
+	/* Omnivision ov8856 */
+	CIO2_SENSOR_CONFIG("OVTI8856", 3, 180000000, 360000000, 720000000),
+	/* Omnivision ov2740 */
+	CIO2_SENSOR_CONFIG("INT3474", 1, 360000000),
+	/* Hynix hi556 */
+	CIO2_SENSOR_CONFIG("INT3537", 1, 437000000),
+	/* Omnivision ov13b10 */
+	CIO2_SENSOR_CONFIG("OVTIDB10", 1, 560000000),
 };
 
 static const struct cio2_property_names prop_names = {